Release Tracking

[github-actions]

This is a scheduled issue for tracking the release between Monday, November 18th and Monday, December 2nd

Last week	Value
Issue
Conductor	@TylerJDev
Release Pull Request	Link
Integration tests	Link

Timeline

• Monday, November 18th
  • Created release PR in Dotcom
• Tuesday, November 19th
  • Merged in fixes for CI, currently 🟢
• Wednesday, November 20th
  • No update
• Thursday, November 21st
  • Created integration test PR off of release tracking PR, CI currently 🔴
• Friday, November 22nd
  • Updated integration test PR, CI currently 🟢
  • Tested UI in review lab
• Monday, November 25th
  • Created new integration test PR, CI currently 🟢
  • Tested UI in review lab, looks good with small visual regression in PageLayout (under FF)
• Tuesday, November 26th
  • Integration test PR CI currently failing 🔴
  • Release PR CI is currently failing 🔴
• Wednesday, November 27th
  • Integration test PR CI currently 🟢
  • Merged in release tracking PR in PRC
  • CI for release PR is currently 🟢
• Thursday, November 28th
  • Holiday, no updates
• Friday, November 29th
  • Holiday, no updates
• Monday, December 2nd
  • TODO: Final Review Lab testing
  • TODO: Get reviews from owning services

Checklist

• Checks have passed on the integration Pull Request downstream
• Release tracking Pull Request has been merged
• Stable release available on npm
• Downstream repos have been updated to latest

Notes

[TylerJDev]

Holding off releasing this week (Nov 18th-22nd), with the aim to release next week. Most PRs are behind FFs, or CSS module work related, so nothing critical to ship yet.

[TylerJDev]

CSS module components reviewed in RL:

• Textarea (0 instances) ⚪
• TextInput (1 instances) ✅
  • Copilot ✅
• Breadcrumbs (1 instances) ✅
  • Marketplace ✅
• PageLayout (3 instances) ❌
  • Marketplace ❌
  • Code view ❌
  • Search ✅
  • Repository ✅
• DialogV2 (3 instances) ✅
  • Set status ✅
  • Create new issue ✅
  • Projects filter ✅
• TreeView (0 instances) ⚪
• ProgressBar (1 instances) ✅
  • Issue progress (projects) ✅
• Popover (0 instances) ⚪
• CheckboxGroup (0 instances) ⚪
• Label (0 instances) ⚪
• SelectPanel2 (0 instances) ⚪
• Timeline (0 instances) ⚪

Locations reviewed in RL:

• User homepage
• Repository homepage
• PR view
• Code view
• Issues
• Projects
• Marketplace
• Search

Visual regressions found:

• PageLayout
  • Padding is slightly different, appears to be missing padding: 24px style when viewport min-width is 1012px (example page)

[TylerJDev]

CI is currently failing in both the upgrade PR and the integration test PR. I'm going to try to debug the failures, as we haven't had too many ships in PRC between now and yesterday. If I'm unable to fully debug it today, I will delay the release until next week due to the short week and upcoming freeze.

Edit 1: Still unable to determine the exact cause of the failures. Re-ran CI on both the integration test and the upgrade PR and still getting failures. Some tests pass after being re-ran, but others stay present. When running the exact tests in dev, the tests pass.

Edit 2: Was able to get the CI green in both the integration test, and the update PR. It appears that the tests that were timing out, and increasing the timeout by 5 seconds allowed the CI to pass consistently. I've raised this issue with the team that owns the test, and include that change in the upgrade PR. It appears that this issue was brought up elsewhere too, https://github.com/github/github/issues/352737.

Edit 3: After some testing, it seems like a small amount of tests in Dotcom take slightly longer after the changes in @primer/react@37.6.0. This isn't a blocker for releasing as a majority of changes are behind feature flags, but an observation I wanted to make note of while debugging the timeout issues.

[TylerJDev]

Aiming to release next Monday (Dec 1st), will try to get some approvals in today to make the merge easier come Monday.

Edit: It appears that the "soft" freeze lasts until late Monday evening. This might push it towards Tuesday if we want to avoid deploying during the freeze. We still need a handful more approvals from owning services, so this might push the release towards Tuesday regardless.