-
Notifications
You must be signed in to change notification settings - Fork 645
Closed
Labels
Description
As the MarkdownEditor component gets used in more places, we'll naturally identify some followup tasks to complete after the initial draft release. Personally I need to shift focus back to some other priorities so I can't tackle these myself right now, which is why I wanted to catalog them somewhere:
- Consumers should only be able to use refs of the exact type
Ref<MarkdownEditorHandle>(currently any ref assignable to that type is allowed, which enables consumers to incorrectly useRef<HTMLTextAreaElement>accidentally) - The component should log an error if no
MarkdownEditor.Labelchild is found - this creates afieldsetwith nolegend - Users should be able to switch between view/edit modes with Cmd+Shift+P
- The task list icon should be updated to be consistent with the new icon used in the Rails-based editor (task list instead of checkbox)
- Will be automatically fixed when
@primer/octicons-reactis updated
- Will be automatically fixed when
- All examples in the
MarkdownViewerdocs haveTypeError: Cannot read properties of undefined (reading '__html')
alexus37