update SelectPanel default empty state message (#6373)

Author: llastflowers

.changeset/curvy-badgers-care.md

@@ -0,0 +1,5 @@
+---
+"@primer/react": patch
+---
+
+update SelectPanel default empty state message to be more generic

.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Default-forced-colors-dark-modern-action-list--true-linux.png

@@ -164,7 +164,7 @@
     {
       "name": "message",
       "type": "{title: string | React.ReactElement; variant: 'empty' | 'error' | 'warning';  body: React.ReactNode;}",
-      "defaultValue": "A default empty message is provided by default if this option is not supplied",
+      "defaultValue": "A default empty message is provided if this option is not configured. Supply a custom empty message to override the default.",
       "description": "Message to display in the panel in case of error or empty results"
     },
     {

packages/react/src/SelectPanel/SelectPanel.docs.json

@@ -92,8 +92,8 @@ export const Default = () => {
           filteredItems.length === 0
             ? {
                 variant: 'empty',
-                title: `No language found for \`${filter}\``,
-                body: 'Adjust your search term to find other languages',
+                title: 'No items available',
+                body: '',
               }
             : undefined
         }

packages/react/src/SelectPanel/SelectPanel.stories.tsx

@@ -765,9 +765,7 @@ for (const useModernActionList of [false, true]) {
 
           jest.runAllTimers()
           await waitFor(async () => {
-            expect(getLiveRegion().getMessage('polite')).toBe(
-              "You haven't created any items yet. Please add or create new items to populate the list.",
-            )
+            expect(getLiveRegion().getMessage('polite')).toBe('No items available. ')
           })
           jest.useRealTimers()
         })
@@ -849,8 +847,7 @@ for (const useModernActionList of [false, true]) {
           expect(screen.getAllByRole('option')).toHaveLength(3)
 
           await user.type(document.activeElement!, 'something')
-          expect(screen.getByText("You haven't created any items yet")).toBeVisible()
-          expect(screen.getByText('Please add or create new items to populate the list.')).toBeVisible()
+          expect(screen.getByText('No items available')).toBeVisible()
         })
 
         it('should display the default empty state message when there is no item after the initial load (No custom message is provided)', async () => {
@@ -860,8 +857,7 @@ for (const useModernActionList of [false, true]) {
 
           await waitFor(async () => {
             await user.click(screen.getByText('Select items'))
-            expect(screen.getByText("You haven't created any items yet")).toBeVisible()
-            expect(screen.getByText('Please add or create new items to populate the list.')).toBeVisible()
+            expect(screen.getByText('No items available')).toBeVisible()
           })
         })
         it('should display the custom empty state message when there is no matching item after filtering', async () => {

packages/react/src/SelectPanel/SelectPanel.test.tsx

@@ -31,8 +31,8 @@ import type {ButtonProps, LinkButtonProps} from '../Button/types'
 const SHORT_DELAY_MS = 500
 const LONG_DELAY_MS = 1000
 const EMPTY_MESSAGE = {
-  title: "You haven't created any items yet",
-  description: 'Please add or create new items to populate the list.',
+  title: 'No items available',
+  description: '',
 }
 
 const DefaultEmptyMessage = (