-
Notifications
You must be signed in to change notification settings - Fork 646
update SelectPanel default empty state message #6373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update SelectPanel default empty state message #6373
Conversation
…documentation accordingly
🦋 Changeset detectedLatest commit: 84eeef6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
Updated the default empty state message for SelectPanel to be more generic.
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/392458 |
|
🟢 golden-jobs completed with status |
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the SelectPanel component's default empty state message to be more generic and applicable across different use cases. The change removes the assumption that users are creating items and instead provides a neutral "No items available" message.
- Replace specific "You haven't created any items yet" message with generic "No items available"
- Remove descriptive text to make the message more universally applicable
- Update all related tests and documentation to reflect the new default message
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/SelectPanel/SelectPanel.tsx | Updates the default empty message constants to use generic messaging |
| packages/react/src/SelectPanel/SelectPanel.test.tsx | Updates test assertions to match the new default empty state message |
| packages/react/src/SelectPanel/SelectPanel.stories.tsx | Updates Storybook story to demonstrate the new default message |
| packages/react/src/SelectPanel/SelectPanel.docs.json | Improves documentation clarity for the message prop default behavior |
| .changeset/curvy-badgers-care.md | Adds changeset entry for the patch release |
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
francinelucca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
Update SelectPanel default empty state message and update tests and message prop documentation accordingly
Relates to https://github.com/github/primer/issues/5377
(Future PR to update primer-docs will close this issue)
Changelog
Changed
Rollout strategy
Testing & Reviewing
On the Default SelectPanel story in Storybook, input filter terms that will yield no results to see the new default message appear.
Merge checklist