Skip to content

Conversation

@llastflowers
Copy link
Contributor

@llastflowers llastflowers commented Jul 23, 2025

Update SelectPanel default empty state message and update tests and message prop documentation accordingly

Relates to https://github.com/github/primer/issues/5377
(Future PR to update primer-docs will close this issue)

Changelog

Changed

  • Update default empty state message to be more generic
  • Update message prop documentation accordingly
  • Update relevant unit tests to match
  • Update Default SelectPanel story to show new default message when no results are found while filtering

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

On the Default SelectPanel story in Storybook, input filter terms that will yield no results to see the new default message appear.

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Jul 23, 2025

🦋 Changeset detected

Latest commit: 84eeef6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.21 KB (-0.13% 🔽)
packages/react/dist/browser.umd.js 92.39 KB (-0.1% 🔽)

@github-actions github-actions bot requested a deployment to storybook-preview-6373 July 23, 2025 19:16 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6373 July 23, 2025 19:27 Inactive
Updated the default empty state message for SelectPanel to be more generic.
@llastflowers llastflowers added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 23, 2025
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/392458

@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 23, 2025
@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 23, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 23, 2025
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@llastflowers llastflowers marked this pull request as ready for review July 23, 2025 20:31
Copilot AI review requested due to automatic review settings July 23, 2025 20:31
@llastflowers llastflowers requested review from a team as code owners July 23, 2025 20:31
@llastflowers llastflowers requested a review from langermank July 23, 2025 20:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the SelectPanel component's default empty state message to be more generic and applicable across different use cases. The change removes the assumption that users are creating items and instead provides a neutral "No items available" message.

  • Replace specific "You haven't created any items yet" message with generic "No items available"
  • Remove descriptive text to make the message more universally applicable
  • Update all related tests and documentation to reflect the new default message

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/react/src/SelectPanel/SelectPanel.tsx Updates the default empty message constants to use generic messaging
packages/react/src/SelectPanel/SelectPanel.test.tsx Updates test assertions to match the new default empty state message
packages/react/src/SelectPanel/SelectPanel.stories.tsx Updates Storybook story to demonstrate the new default message
packages/react/src/SelectPanel/SelectPanel.docs.json Improves documentation clarity for the message prop default behavior
.changeset/curvy-badgers-care.md Adds changeset entry for the patch release

@github-actions github-actions bot temporarily deployed to storybook-preview-6373 July 23, 2025 20:34 Inactive
@llastflowers llastflowers added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 23, 2025
@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 23, 2025
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 23, 2025
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 23, 2025
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 23, 2025
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot requested a deployment to storybook-preview-6373 July 23, 2025 21:12 Abandoned
@francinelucca francinelucca enabled auto-merge July 23, 2025 21:20
@joshblack joshblack disabled auto-merge July 23, 2025 21:22
@joshblack joshblack merged commit 95c23ac into main Jul 23, 2025
43 checks passed
@joshblack joshblack deleted the llastflowers/5377/SelectPanel-default-empty-message branch July 23, 2025 21:22
@primer primer bot mentioned this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants