Add optional chain to return #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3de0238 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an error when a specifier's "imported" property is missing by adding optional chaining support.
- Update in rule file to use optional chaining on "specifier.imported.name" when checking existence in the "entrypoint" map.
- Addition of a test case to cover wildcard import usage.
- A changeset update documenting the fix.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/rules/no-deprecated-experimental-components.js | Use optional chaining to safely access specifier.imported.name |
| src/rules/tests/no-deprecated-experimental-components.test.js | Added test case for wildcard import scenario |
| .changeset/proud-terms-fetch.md | Documents the fix for missing "imported" in specifier objects |
Co-authored-by: Copilot <[email protected]>
jonrohan
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error when
importeddoes not exist in the specifier object. Adds an optional chain to return for cases whereimportedisn't present.