Skip to content

Conversation

@keithamus
Copy link
Contributor

Closes https://github.com/github/primer/issues/4355, https://github.com/github/primer/issues/4356

This adds a lint rule which enforces CSS modules be imported a certain way - with default imports, instead of named, and the default name must match a certain pattern.

@keithamus keithamus requested a review from a team as a code owner October 25, 2024 17:48
@keithamus keithamus requested a review from jonrohan October 25, 2024 17:48
@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: 693b951

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-primer-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@keithamus keithamus merged commit 90134bc into main Oct 28, 2024
8 checks passed
@keithamus keithamus deleted the add-enforce-css-module-default-import-rule branch October 28, 2024 20:44
@primer-css primer-css mentioned this pull request Oct 25, 2024
@@ -0,0 +1,88 @@
const rule = require('../enforce-css-module-default-import')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js.test.js: #326 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants