Skip to content

Fix Stack system prop #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Fix Stack system prop #212

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2588cb4
add rule
langermank Aug 28, 2024
7e363bb
Create nervous-coats-cross.md
langermank Aug 28, 2024
36f2ec4
Update .changeset/nervous-coats-cross.md
siddharthkp Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nervous-coats-cross.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"eslint-plugin-primer-react": patch
---

Fix `Stack` system prop for padding and gap
1 change: 1 addition & 0 deletions src/rules/no-system-props.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ const excludedComponentProps = new Map([
['ProgressBar', new Set(['bg'])],
['PointerBox', new Set(['bg'])],
['Truncate', new Set(['maxWidth'])],
['Stack', new Set(['padding', 'gap'])],
])

const alwaysExcludedProps = new Set(['variant', 'size'])
Expand Down