Skip to content
This repository was archived by the owner on Jul 7, 2025. It is now read-only.

Toggle switch component guidelines #249

Merged
merged 12 commits into from
Mar 30, 2022
Merged

Toggle switch component guidelines #249

merged 12 commits into from
Mar 30, 2022

Conversation

@mperrotti
Copy link
Contributor

@mperrotti mperrotti commented Mar 22, 2022

No description provided.

@mperrotti mperrotti requested a review from a team as a code owner March 22, 2022 23:52
@vercel
Copy link

vercel bot commented Mar 22, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/design/6UMDSHrdVjKA65j5MKNqQjGW5xdr
✅ Preview: https://design-git-mp-toggle-switch-guidelines-primer.vercel.app

@mperrotti mperrotti mentioned this pull request Mar 23, 2022
Merged
6 tasks
yaili
yaili suggested changes Mar 23, 2022
View reviewed changes
Copy link
Member

@yaili yaili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments, you also need to add the component to this page 😄

@mperrotti mperrotti requested a review from yaili March 24, 2022 14:58
yaili
yaili approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@yaili yaili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

ichelsea
ichelsea reviewed Mar 28, 2022
View reviewed changes
Copy link
Contributor

@ichelsea ichelsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple suggestions 🙂

@mperrotti mperrotti merged commit 9b6e624 into main Mar 30, 2022
@mperrotti mperrotti deleted the mp/toggle-switch-guidelines branch March 30, 2022 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ichelsea ichelsea ichelsea left review comments

@yaili yaili yaili approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mperrotti @yaili @ichelsea