Bump @primer/primitives to 7.11.5
#2421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7972c58 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
@primer/[email protected]
98ca36aThanks @lukasoppermann! - Fix for primary color in cvd modes@primer/[email protected]
c9101b7Thanks @lukasoppermann! - Updated fg.default and fg.muted for most themes to reset to previous versionsThese color changes fix regressions in non-default themes. The most noticeable is fixing the color blind themes where the Primary Button should be blue instead of green, reported here: https://github.com/orgs/community/discussions/51943
What approach did you choose and why?
What should reviewers focus on?
Note that this is not super urgent since we added the
@primer/primitivesdirectly to dotcom and in our docs we only show the default light/dark themes.Can these changes ship as is?