Skip to content

Performance improvements: Check log level. Allow non-default json lib. #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Performance improvements: Check log level. Allow non-default json lib. #102

wants to merge 3 commits into from

Conversation

100LL
Copy link
Member

@100LL 100LL commented Jan 5, 2021

  • Check the log level and prevent unnecessary calls to logger. In testing this resulted in a 15% decrease in query time.
  • Allow user to pass in a different json library. Using ujson instead of the json library built in to requests, combined with the above change, resulted in a 24% decrease in query time.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 5, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@100LL 100LL requested a review from neeradsomanchi January 5, 2021 04:48
@cliandy cliandy mentioned this pull request Jul 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neeradsomanchi neeradsomanchi Awaiting requested review from neeradsomanchi

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@100LL