Implement Obelisk Core #8
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was vanishingly little benifit to keeping them separate, merging them makes importing easier.
It's still Keycloak, so essentially the same as HFS. The URLs will still need changing in the future.
This implements purely the async part of Core compatibility, and only basic submit and querying. Time-based chunking is not yet implemented, but a placeholder method definition is provided as a reminder. The query interface is very bare-bones and requires the user to write RSQL queries themselves.
This does not at this time support custom filters, because that would be a nightmare in the RSQL format.
Epse
force-pushed
the
integrate_obelisk_core
branch
2 times, most recently
from
8d66376 to
247ef3d
Compare
They are always AND'ed together, for fairly obvious reasons. This removes the previous metric filter, because users can now add this in the filter field.
Epse
force-pushed
the
integrate_obelisk_core
branch
from
247ef3d to
8b102e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should eventually end up implementing Obelisk Core
Also refactors the codebase into one
Obeliskclass, rather than splitConsumerandProducer. The tests are now in a separate module, partly to hide them in the docs.Closes #5