Docs for new spotx bidder #1110
Conversation
muuki88
left a comment
muuki88
left a comment
There was a problem hiding this comment.
Yeeaah! 🎉 fixed documentation
muuki88
left a comment
muuki88
left a comment
There was a problem hiding this comment.
Yeeaah! 🎉 fixed documentation
dev-docs/bidders/spotx.md
Outdated
| | `custom_override` | optional | Object of script tag attributes to override from the list here: [EASI Attributes](https://developer.spotxchange.com/content/local/docs/sdkDocs/EASI/README.md#common-javascript-attributes) | ||
| NOTES: | ||
| * exclude 'data-spotx_' from attribute name. | ||
| * channel_id, vast_url, content_page_url, and ad_unit overrides are ignored | `{content_height: 300, ontent_width: 400}` | `object` | |
There was a problem hiding this comment.
Typo content_width missing c
| | `hide_skin` | optional | Set to true to hide the spotx skin | | `boolean` | | ||
| | `custom` | optional | See SpotX documentation [here](https://developer.spotxchange.com/content/local/docs/sdkDocs/DirectSdk/README.md#custom-property-for-key-value-pair-reporting) | | `object` | | ||
|
|
||
| <a name="spotx-outstream-options-object |
There was a problem hiding this comment.
Link object seems to be broken
There was a problem hiding this comment.
When I ran this through a markdown parser, the link worked as expected. This github repo isn't parsing these right, but it should look correct when it's published.
| |----------------------|----------|---------------------------------------------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-------------| | ||
| | `channel_id` | required | A unique 5 digit ID that is generated by the SpotX publisher platform when a channel is created | `'85394'` | `string` | | ||
| | `ad_unit` | required | Token that describes which ad unit to play: instream or outstream | `'outstream'` | `string` | | ||
| | `outstream_function` | optional | Custom function to be used as a renderer. | `function(bid){console.log(bid);}` | `function` | |
There was a problem hiding this comment.
What is the bid input parameter?
There was a problem hiding this comment.
This is the bid parameter that is passed to all renderers: http://prebid.org/dev-docs/show-outstream-video-ads.html#renderers
|
released with pbjs 2.1 - merging |
|
Looks a bit weird. When I remove the |
|
Ya, it's weird... I modeled after all the other .md files, that's why I expected the publish to change it. For example, the AppNexus page has all the same elements this one does... I'm not sure what's different. https://prebid.org/dev-docs/bidders/appnexus.html @bretg any suggestions on what's wrong? |
3 participants
No description provided.