Skip to content

Conversation

@rschristian
Copy link
Member

@rschristian rschristian commented Oct 13, 2024

This should correct the PR reporter

There's no elegant way to watch jobs within a workflow, so we'll have to settle for mirroring CI's filter here to ensure we're only running the PR reporter when the benchmarks will be ran (**/src/**/*.js)

# Should be kept in sync with the filter in the PR Reporter workflow
filters: |
jsChanged: '**/src/**.js'
jsChanged: '**/src/**/*.js'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we found in ad1fdf5

@coveralls
Copy link

Coverage Status

coverage: 99.488%. remained the same
when pulling 21956d6 on ci/fix-pr-reporter
into 162d71f on main.

@rschristian rschristian merged commit 8deab11 into main Oct 13, 2024
7 checks passed
@rschristian rschristian deleted the ci/fix-pr-reporter branch October 13, 2024 06:31
@JoviDeCroock JoviDeCroock mentioned this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants