Skip to content

fix(debug): check not firing when p/a/button has a parent #4449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix(debug): check not firing when p/a/button has a parent #4449

merged 1 commit into from
Jul 19, 2024

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Jul 19, 2024

The dom-parent name check is only relevant for table elements, for p/a/button this would stop us from running our checks.

@github-actions
Copy link

github-actions bot commented Jul 19, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +2% (-11.82ms - +15.03ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -3% - +1% (-0.52ms - +0.12ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +4% (-2.55ms - +2.94ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -3% - +4% (-0.45ms - +0.71ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +3% (-0.82ms - +2.57ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +2% (-0.10ms - +0.03ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +2% (-0.13ms - +0.53ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +1% (-0.08ms - +0.39ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +1% (-0.26ms - +0.17ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.02ms - +0.03ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local870.98ms - 889.88ms-unsure 🔍
-1% - +2%
-11.82ms - +15.03ms
preact-main869.29ms - 888.36msunsure 🔍
-2% - +1%
-15.03ms - +11.82ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local25.15ms - 25.16ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main25.15ms - 25.15msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.61ms - 16.74ms-unsure 🔍
-3% - +1%
-0.52ms - +0.12ms
preact-main16.56ms - 17.19msunsure 🔍
-1% - +3%
-0.12ms - +0.52ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.69ms - 1.70ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.69ms - 1.70msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local75.49ms - 79.39ms-unsure 🔍
-3% - +4%
-2.55ms - +2.94ms
preact-main75.31ms - 79.18msunsure 🔍
-4% - +3%
-2.94ms - +2.55ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local13.13ms - 13.40ms-unsure 🔍
-2% - +1%
-0.26ms - +0.17ms
preact-main13.14ms - 13.47msunsure 🔍
-1% - +2%
-0.17ms - +0.26ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.81ms - 17.76ms-unsure 🔍
-3% - +4%
-0.45ms - +0.71ms
preact-main16.81ms - 17.49msunsure 🔍
-4% - +3%
-0.71ms - +0.45ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.62ms - 4.62ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main4.62ms - 4.62msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local76.16ms - 78.36ms-unsure 🔍
-1% - +3%
-0.82ms - +2.57ms
preact-main75.09ms - 77.68msunsure 🔍
-3% - +1%
-2.57ms - +0.82ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.52ms - 3.55ms-unsure 🔍
-1% - +1%
-0.02ms - +0.03ms
preact-main3.51ms - 3.54msunsure 🔍
-1% - +1%
-0.03ms - +0.02ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local29.18ms - 29.95ms-unsure 🔍
-0% - +3%
-0.00ms - +0.94ms
preact-main28.82ms - 29.37msunsure 🔍
-3% - -0%
-0.94ms - +0.00ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local33.16ms - 34.98ms-unsure 🔍
-7% - +1%
-2.44ms - +0.21ms
preact-main34.22ms - 36.15msunsure 🔍
-1% - +7%
-0.21ms - +2.44ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local25.25ms - 25.90ms-unsure 🔍
-2% - +2%
-0.47ms - +0.40ms
preact-main25.31ms - 25.90msunsure 🔍
-2% - +2%
-0.40ms - +0.47ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local30.57ms - 32.04ms-unsure 🔍
-3% - +4%
-0.98ms - +1.26ms
preact-main30.32ms - 32.01msunsure 🔍
-4% - +3%
-1.26ms - +0.98ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local21.80ms - 22.99ms-unsure 🔍
-6% - +2%
-1.39ms - +0.45ms
preact-main22.17ms - 23.57msunsure 🔍
-2% - +6%
-0.45ms - +1.39ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local23.03ms - 23.99ms-unsure 🔍
-5% - +1%
-1.14ms - +0.29ms
preact-main23.40ms - 24.46msunsure 🔍
-1% - +5%
-0.29ms - +1.14ms		-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.89ms - 1.99ms-unsure 🔍
-5% - +2%
-0.10ms - +0.03ms
preact-main1.92ms - 2.02msunsure 🔍
-2% - +5%
-0.03ms - +0.10ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.98ms - 0.98ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main0.98ms - 0.98msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local25.63ms - 26.23ms-unsure 🔍
-0% - +2%
-0.13ms - +0.53ms
preact-main25.61ms - 25.86msunsure 🔍
-2% - +0%
-0.53ms - +0.13ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.25ms - 1.25msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local28.91ms - 29.25ms-unsure 🔍
-0% - +1%
-0.08ms - +0.39ms
preact-main28.76ms - 29.08msunsure 🔍
-1% - +0%
-0.39ms - +0.08ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.55ms - 3.55ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main3.55ms - 3.55msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link

github-actions bot commented Jul 19, 2024

Size Change: +2 B (0%)

Total Size: 62 kB

Filename Size Change
debug/dist/debug.js 3.7 kB +1 B (+0.03%)
debug/dist/debug.umd.js 3.78 kB +1 B (+0.03%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.1 kB
compat/dist/compat.module.js 4.03 kB
compat/dist/compat.umd.js 4.17 kB
debug/dist/debug.module.js 3.71 kB
devtools/dist/devtools.js 259 B
devtools/dist/devtools.module.js 273 B
devtools/dist/devtools.umd.js 345 B
dist/preact.js 4.72 kB
dist/preact.min.js 4.75 kB
dist/preact.min.module.js 4.75 kB
dist/preact.min.umd.js 4.78 kB
dist/preact.module.js 4.74 kB
dist/preact.umd.js 4.8 kB
hooks/dist/hooks.js 1.53 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 981 B
jsx-runtime/dist/jsxRuntime.module.js 956 B
jsx-runtime/dist/jsxRuntime.umd.js 1.06 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@coveralls
Copy link

coveralls commented Jul 19, 2024

Coverage Status

Changes unknown
when pulling 0cdc8d2 on fix-debug-check
into ** on main**.

@JoviDeCroock JoviDeCroock merged commit 16c7fb7 into main Jul 19, 2024
@JoviDeCroock JoviDeCroock deleted the fix-debug-check branch July 19, 2024 08:09
@JoviDeCroock JoviDeCroock mentioned this pull request Jul 20, 2024
Merged
This was referenced Aug 14, 2024
Open
Open
This was referenced Sep 3, 2024
Open
Open
@arkid15r arkid15r mentioned this pull request Sep 11, 2024
Closed
@ntavassoli-dot ntavassoli-dot mentioned this pull request Sep 13, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 5, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 18, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 25, 2024
Open
@Xcaciv Xcaciv mentioned this pull request Oct 27, 2024
Open
@dwhiteGUK dwhiteGUK mentioned this pull request Oct 28, 2024
Closed
@X-oss-byte X-oss-byte mentioned this pull request Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rschristian rschristian rschristian approved these changes

@developit developit Awaiting requested review from developit

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

@marvinhagemeister marvinhagemeister Awaiting requested review from marvinhagemeister

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JoviDeCroock @coveralls @rschristian