fix(child-diffing): Should shift keyed fragmented lists #4448

JoviDeCroock · 2024-07-18T18:53:30Z

oldDom would become stale when we were diving through a reorderChildren sequence, this implements the same fix as we have in children.js where we look for up to date dom siblings when the parent does not contain the oldDom, implying it's unmounted.

test with fix: check whether oldDom is present in the DOM #4318
test with only check is connected for dom nodes #4409

github-actions · 2024-07-18T18:53:45Z

📊 Tachometer Benchmark Results

Summary

duration

create10k: unsure 🔍 -2% - +2% (-16.02ms - +18.83ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -1% - +3% (-0.21ms - +0.46ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -3% - +1% (-2.24ms - +0.87ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -3% - +3% (-0.57ms - +0.54ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -1% - +3% (-0.93ms - +2.39ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 -5% - +1% (-0.09ms - +0.01ms)
^{preact-local vs preact-main}
todo: unsure 🔍 -2% - +1% (-0.54ms - +0.24ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 -3% - +2% (-1.17ms - +0.74ms)
^{preact-local vs preact-main}

usedJSHeapSize

create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -1% - +2% (-0.14ms - +0.32ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -0% - +1% (-0.01ms - +0.04ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
^{preact-local vs preact-main}
todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-main}

Results

create10k

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1606
Commit: 8c2c662

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	881.84ms - 907.54ms	-	unsure 🔍 -2% - +2% -16.02ms - +18.83ms
preact-main	881.52ms - 905.06ms	unsure 🔍 -2% - +2% -18.83ms - +16.02ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.15ms - 25.15ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	25.15ms - 25.15ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

filter-list

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1606
Commit: 8c2c662

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.51ms - 17.17ms	-	unsure 🔍 -1% - +3% -0.21ms - +0.46ms
preact-main	16.65ms - 16.78ms	unsure 🔍 -3% - +1% -0.46ms - +0.21ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.69ms - 1.70ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	1.69ms - 1.70ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

hydrate1k

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1606
Commit: 8c2c662

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	70.29ms - 71.87ms	-	unsure 🔍 -3% - +1% -2.24ms - +0.87ms
preact-main	70.42ms - 73.10ms	unsure 🔍 -1% - +3% -0.87ms - +2.24ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	15.55ms - 15.92ms	-	unsure 🔍 -1% - +2% -0.14ms - +0.32ms
preact-main	15.51ms - 15.78ms	unsure 🔍 -2% - +1% -0.32ms - +0.14ms	-

many-updates

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1606
Commit: 8c2c662

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.59ms - 17.33ms	-	unsure 🔍 -3% - +3% -0.57ms - +0.54ms
preact-main	16.55ms - 17.39ms	unsure 🔍 -3% - +3% -0.54ms - +0.57ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	4.61ms - 4.61ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	4.61ms - 4.61ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

replace1k

Browser: chrome-headless
Sample size: 100
Built by: Benchmarks #1606
Commit: 8c2c662

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	73.98ms - 76.25ms	-	unsure 🔍 -1% - +3% -0.93ms - +2.39ms
preact-main	73.17ms - 75.60ms	unsure 🔍 -3% - +1% -2.39ms - +0.93ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.54ms - 3.57ms	-	unsure 🔍 -0% - +1% -0.01ms - +0.04ms
preact-main	3.52ms - 3.55ms	unsure 🔍 -1% - +0% -0.04ms - +0.01ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	28.93ms - 29.52ms	-	unsure 🔍 -1% - +2% -0.17ms - +0.58ms
preact-main	28.79ms - 29.26ms	unsure 🔍 -2% - +1% -0.58ms - +0.17ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.89ms - 35.74ms	-	unsure 🔍 -3% - +5% -0.96ms - +1.71ms
preact-main	33.48ms - 35.40ms	unsure 🔍 -5% - +3% -1.71ms - +0.96ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	24.81ms - 25.40ms	-	unsure 🔍 -1% - +2% -0.28ms - +0.47ms
preact-main	24.78ms - 25.24ms	unsure 🔍 -2% - +1% -0.47ms - +0.28ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	29.91ms - 31.31ms	-	unsure 🔍 -1% - +6% -0.23ms - +1.69ms
preact-main	29.23ms - 30.53ms	unsure 🔍 -5% - +1% -1.69ms - +0.23ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	21.53ms - 23.31ms	-	unsure 🔍 -7% - +3% -1.54ms - +0.80ms
preact-main	22.04ms - 23.55ms	unsure 🔍 -4% - +7% -0.80ms - +1.54ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	22.45ms - 23.33ms	-	unsure 🔍 -4% - +2% -0.99ms - +0.38ms
preact-main	22.66ms - 23.72ms	unsure 🔍 -2% - +4% -0.38ms - +0.99ms	-

text-update

Browser: chrome-headless
Sample size: 190
Built by: Benchmarks #1606
Commit: 8c2c662

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.89ms - 1.96ms	-	unsure 🔍 -5% - +1% -0.09ms - +0.01ms
preact-main	1.93ms - 2.00ms	unsure 🔍 -1% - +5% -0.01ms - +0.09ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	0.98ms - 0.98ms	-	unsure 🔍 -0% - -0% -0.00ms - -0.00ms
preact-main	0.98ms - 0.98ms	unsure 🔍 +0% - +0% +0.00ms - +0.00ms	-

todo

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1606
Commit: 8c2c662

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	26.54ms - 27.07ms	-	unsure 🔍 -2% - +1% -0.54ms - +0.24ms
preact-main	26.66ms - 27.25ms	unsure 🔍 -1% - +2% -0.24ms - +0.54ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.25ms - 1.25ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	1.25ms - 1.25ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

update10th1k

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1606
Commit: 8c2c662

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	32.78ms - 34.20ms	-	unsure 🔍 -3% - +2% -1.17ms - +0.74ms
preact-main	33.08ms - 34.35ms	unsure 🔍 -2% - +4% -0.74ms - +1.17ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.55ms - 3.55ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	3.55ms - 3.55ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

_{tachometer-reporter-action v2 for Benchmarks}

github-actions · 2024-07-18T18:54:41Z

Size Change: -31 B (-0.05%)

Total Size: 62 kB

Filename	Size	Change
`dist/preact.js`	4.72 kB	-5 B (-0.11%)
`dist/preact.min.js`	4.75 kB	-5 B (-0.11%)
`dist/preact.min.module.js`	4.75 kB	-5 B (-0.11%)
`dist/preact.min.umd.js`	4.77 kB	-5 B (-0.1%)
`dist/preact.module.js`	4.74 kB	-6 B (-0.13%)
`dist/preact.umd.js`	4.79 kB	-5 B (-0.1%)

ℹ️ View Unchanged

Filename	Size
`compat/dist/compat.js`	4.1 kB
`compat/dist/compat.module.js`	4.03 kB
`compat/dist/compat.umd.js`	4.17 kB
`debug/dist/debug.js`	3.7 kB
`debug/dist/debug.module.js`	3.71 kB
`debug/dist/debug.umd.js`	3.78 kB
`devtools/dist/devtools.js`	259 B
`devtools/dist/devtools.module.js`	273 B
`devtools/dist/devtools.umd.js`	345 B
`hooks/dist/hooks.js`	1.53 kB
`hooks/dist/hooks.module.js`	1.56 kB
`hooks/dist/hooks.umd.js`	1.6 kB
`jsx-runtime/dist/jsxRuntime.js`	981 B
`jsx-runtime/dist/jsxRuntime.module.js`	956 B
`jsx-runtime/dist/jsxRuntime.umd.js`	1.06 kB
`test-utils/dist/testUtils.js`	451 B
`test-utils/dist/testUtils.module.js`	456 B
`test-utils/dist/testUtils.umd.js`	536 B

_{compressed-size-action}

coveralls · 2024-07-18T18:55:45Z

coverage: 99.486% (-0.1%) from 99.614%
when pulling 8c2c662 on fragment-like-keyed-children
into 16c7fb7 on main.

JoviDeCroock requested review from andrewiggins, developit and marvinhagemeister July 18, 2024 18:53

Should shift keyed fragmented lists

eb63908

JoviDeCroock force-pushed the fragment-like-keyed-children branch from a9293a2 to eb63908 Compare July 18, 2024 18:54

cleanup old usage of oldDom

559cef5

JoviDeCroock force-pushed the fragment-like-keyed-children branch from 5593486 to 559cef5 Compare July 18, 2024 19:50

marvinhagemeister approved these changes Jul 19, 2024

View reviewed changes

Merge branch 'main' into fragment-like-keyed-children

8c2c662

JoviDeCroock merged commit f573891 into main Jul 19, 2024

JoviDeCroock deleted the fragment-like-keyed-children branch July 19, 2024 09:12

JoviDeCroock mentioned this pull request Jul 20, 2024

10.23.0 #4450

Merged

This was referenced Aug 14, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.23.0 X-oss-byte/next-auth#109

Open

[Snyk] Upgrade preact from 10.11.3 to 10.23.1 X-oss-byte/next-auth#110

Open

This was referenced Sep 3, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.23.2 X-oss-byte/next-auth#113

Open

[Snyk] Upgrade: cookie, preact, preact-render-to-string X-oss-byte/next-auth#115

Open

arkid15r mentioned this pull request Sep 11, 2024

[Snyk] Upgrade: , dayjs, marked-emoji, preact, qs, react-router-dom, sass VictoriaMetrics/VictoriaMetrics#6982

Closed

ntavassoli-dot mentioned this pull request Sep 13, 2024

[Snyk] Upgrade preact from 10.13.2 to 10.23.2 ntavassoli-dot/InstagramUnfollowers#1

Open

X-oss-byte mentioned this pull request Oct 5, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.24.0 X-oss-byte/next-auth#123

Open

X-oss-byte mentioned this pull request Oct 18, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.24.1 X-oss-byte/next-auth#125

Open

X-oss-byte mentioned this pull request Oct 25, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.24.2 X-oss-byte/next-auth#127

Open

Xcaciv mentioned this pull request Oct 27, 2024

[Snyk] Upgrade preact from 10.22.0 to 10.24.2 Xcaciv/appsec-test-2024#3

Open

dwhiteGUK mentioned this pull request Oct 28, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.24.2 dwhiteGUK/dlw.dev#39

Closed

X-oss-byte mentioned this pull request Nov 8, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.24.3 X-oss-byte/next-auth#130

Open

Uh oh!

fix(child-diffing): Should shift keyed fragmented lists #4448

fix(child-diffing): Should shift keyed fragmented lists #4448

Uh oh!

Conversation

JoviDeCroock commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

duration

usedJSHeapSize

Results

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

run-warmup-0

run-warmup-1

run-warmup-2

run-warmup-3

run-warmup-4

run-final

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

Uh oh!

github-actions bot commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JoviDeCroock commented Jul 18, 2024 •

edited

Loading

github-actions bot commented Jul 18, 2024 •

edited

Loading

github-actions bot commented Jul 18, 2024 •

edited

Loading

coveralls commented Jul 18, 2024 •

edited

Loading