fix(hydration): streaming renders #4446

JoviDeCroock · 2024-07-16T15:07:49Z

Discovered in https://github.com/jacob-ebey/preact-ooo-issues CC @jacob-ebey

What happened is that we'd use the <!-- preact-island indicator as our oldDom which made it so that we'd fail our hydration resumption when there was a fallback in Suspense. This because during hydration resumption we only reserve 1 DOM-child for the resume, this fixes it holistically where we exclude comments from being used as our resumption point.

There's an artefact here https://github.com/preactjs/preact/actions/runs/9959423157

There are still existing issues with returning multiple DOM-nodes/... in resumed hydration however that is tackled in #4442 where we'll most likely introduce a second RFC for streaming in particular

github-actions · 2024-07-16T15:08:07Z

📊 Tachometer Benchmark Results

Summary

duration

create10k: unsure 🔍 -1% - +2% (-12.24ms - +18.73ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -2% - +4% (-0.34ms - +0.74ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -4% - +2% (-2.89ms - +1.49ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -2% - +0% (-0.28ms - +0.05ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -3% - +2% (-2.15ms - +1.23ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 -5% - +4% (-0.10ms - +0.08ms)
^{preact-local vs preact-main}
todo: unsure 🔍 -2% - +1% (-0.53ms - +0.14ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 -1% - +3% (-0.39ms - +1.22ms)
^{preact-local vs preact-main}

usedJSHeapSize

create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -3% - +0% (-0.42ms - +0.04ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -0% - +1% (-0.00ms - +0.04ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-main}
todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-main}

Results

create10k

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1586
Commit: 852f511

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	866.92ms - 892.18ms	-	unsure 🔍 -1% - +2% -12.24ms - +18.73ms
preact-main	867.35ms - 885.26ms	unsure 🔍 -2% - +1% -18.73ms - +12.24ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.15ms - 25.15ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	25.15ms - 25.15ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

filter-list

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1586
Commit: 852f511

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.53ms - 17.52ms	-	unsure 🔍 -2% - +4% -0.34ms - +0.74ms
preact-main	16.60ms - 17.05ms	unsure 🔍 -4% - +2% -0.74ms - +0.34ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.69ms - 1.70ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	1.69ms - 1.70ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

hydrate1k

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1586
Commit: 852f511

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	71.01ms - 73.07ms	-	unsure 🔍 -4% - +2% -2.89ms - +1.49ms
preact-main	70.81ms - 74.68ms	unsure 🔍 -2% - +4% -1.49ms - +2.89ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	13.12ms - 13.31ms	-	unsure 🔍 -3% - +0% -0.42ms - +0.04ms
preact-main	13.20ms - 13.61ms	unsure 🔍 -0% - +3% -0.04ms - +0.42ms	-

many-updates

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1586
Commit: 852f511

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.29ms - 16.54ms	-	unsure 🔍 -2% - +0% -0.28ms - +0.05ms
preact-main	16.42ms - 16.64ms	unsure 🔍 -0% - +2% -0.05ms - +0.28ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	4.61ms - 4.62ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	4.61ms - 4.61ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

replace1k

Browser: chrome-headless
Sample size: 100
Built by: Benchmarks #1586
Commit: 852f511

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	73.16ms - 75.58ms	-	unsure 🔍 -3% - +2% -2.15ms - +1.23ms
preact-main	73.65ms - 76.00ms	unsure 🔍 -2% - +3% -1.23ms - +2.15ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.52ms - 3.55ms	-	unsure 🔍 -0% - +1% -0.00ms - +0.04ms
preact-main	3.50ms - 3.53ms	unsure 🔍 -1% - +0% -0.04ms - +0.00ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	28.62ms - 29.19ms	-	unsure 🔍 -1% - +2% -0.39ms - +0.49ms
preact-main	28.52ms - 29.18ms	unsure 🔍 -2% - +1% -0.49ms - +0.39ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	34.33ms - 36.21ms	-	unsure 🔍 -4% - +3% -1.50ms - +1.16ms
preact-main	34.49ms - 36.38ms	unsure 🔍 -3% - +4% -1.16ms - +1.50ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	24.53ms - 25.39ms	-	unsure 🔍 -1% - +3% -0.26ms - +0.71ms
preact-main	24.51ms - 24.96ms	unsure 🔍 -3% - +1% -0.71ms - +0.26ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	29.37ms - 30.86ms	-	unsure 🔍 -4% - +4% -1.16ms - +1.06ms
preact-main	29.34ms - 30.99ms	unsure 🔍 -4% - +4% -1.06ms - +1.16ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	22.44ms - 24.30ms	-	unsure 🔍 -4% - +7% -0.90ms - +1.56ms
preact-main	22.24ms - 23.85ms	unsure 🔍 -7% - +4% -1.56ms - +0.90ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	22.40ms - 23.39ms	-	unsure 🔍 -6% - +0% -1.43ms - +0.01ms
preact-main	23.08ms - 24.13ms	unsure 🔍 -0% - +6% -0.01ms - +1.43ms	-

text-update

Browser: chrome-headless
Sample size: 120
Built by: Benchmarks #1586
Commit: 852f511

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.95ms - 2.10ms	-	unsure 🔍 -5% - +4% -0.10ms - +0.08ms
preact-main	1.99ms - 2.09ms	unsure 🔍 -4% - +5% -0.08ms - +0.10ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	0.98ms - 0.98ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	0.98ms - 0.98ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

todo

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1586
Commit: 852f511

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.93ms - 26.14ms	-	unsure 🔍 -2% - +1% -0.53ms - +0.14ms
preact-main	25.92ms - 26.54ms	unsure 🔍 -1% - +2% -0.14ms - +0.53ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.25ms - 1.25ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	1.25ms - 1.25ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

update10th1k

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1586
Commit: 852f511

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	36.26ms - 37.38ms	-	unsure 🔍 -1% - +3% -0.39ms - +1.22ms
preact-main	35.83ms - 36.98ms	unsure 🔍 -3% - +1% -1.22ms - +0.39ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.55ms - 3.55ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	3.55ms - 3.55ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

_{tachometer-reporter-action v2 for Benchmarks}

github-actions · 2024-07-16T15:08:59Z

Size Change: +101 B (+0.16%)

Total Size: 62 kB

Filename	Size	Change
`dist/preact.js`	4.72 kB	+17 B (+0.36%)
`dist/preact.min.js`	4.75 kB	+15 B (+0.32%)
`dist/preact.min.module.js`	4.75 kB	+17 B (+0.36%)
`dist/preact.min.umd.js`	4.78 kB	+16 B (+0.34%)
`dist/preact.module.js`	4.74 kB	+18 B (+0.38%)
`dist/preact.umd.js`	4.8 kB	+18 B (+0.38%)

ℹ️ View Unchanged

Filename	Size
`compat/dist/compat.js`	4.1 kB
`compat/dist/compat.module.js`	4.03 kB
`compat/dist/compat.umd.js`	4.17 kB
`debug/dist/debug.js`	3.7 kB
`debug/dist/debug.module.js`	3.71 kB
`debug/dist/debug.umd.js`	3.78 kB
`devtools/dist/devtools.js`	259 B
`devtools/dist/devtools.module.js`	273 B
`devtools/dist/devtools.umd.js`	345 B
`hooks/dist/hooks.js`	1.53 kB
`hooks/dist/hooks.module.js`	1.56 kB
`hooks/dist/hooks.umd.js`	1.6 kB
`jsx-runtime/dist/jsxRuntime.js`	981 B
`jsx-runtime/dist/jsxRuntime.module.js`	956 B
`jsx-runtime/dist/jsxRuntime.umd.js`	1.06 kB
`test-utils/dist/testUtils.js`	451 B
`test-utils/dist/testUtils.module.js`	456 B
`test-utils/dist/testUtils.umd.js`	536 B

_{compressed-size-action}

coveralls · 2024-07-16T15:10:06Z

coverage: 99.615% (+0.003%) from 99.612%
when pulling 852f511 on streaming-render-fixes
into f7f9d9b on main.

Publish fixes for streaming renders

852f511

JoviDeCroock requested review from andrewiggins, developit and marvinhagemeister July 16, 2024 15:14

marvinhagemeister approved these changes Jul 16, 2024

View reviewed changes

JoviDeCroock merged commit a75b217 into main Jul 18, 2024

JoviDeCroock deleted the streaming-render-fixes branch July 18, 2024 18:53

JoviDeCroock mentioned this pull request Jul 20, 2024

10.23.0 #4450

Merged

This was referenced Aug 14, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.23.0 X-oss-byte/next-auth#109

Open

[Snyk] Upgrade preact from 10.11.3 to 10.23.1 X-oss-byte/next-auth#110

Open

This was referenced Sep 3, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.23.2 X-oss-byte/next-auth#113

Open

[Snyk] Upgrade: cookie, preact, preact-render-to-string X-oss-byte/next-auth#115

Open

arkid15r mentioned this pull request Sep 11, 2024

[Snyk] Upgrade: , dayjs, marked-emoji, preact, qs, react-router-dom, sass VictoriaMetrics/VictoriaMetrics#6982

Closed

ntavassoli-dot mentioned this pull request Sep 13, 2024

[Snyk] Upgrade preact from 10.13.2 to 10.23.2 ntavassoli-dot/InstagramUnfollowers#1

Open

X-oss-byte mentioned this pull request Oct 5, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.24.0 X-oss-byte/next-auth#123

Open

X-oss-byte mentioned this pull request Oct 18, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.24.1 X-oss-byte/next-auth#125

Open

X-oss-byte mentioned this pull request Oct 25, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.24.2 X-oss-byte/next-auth#127

Open

Xcaciv mentioned this pull request Oct 27, 2024

[Snyk] Upgrade preact from 10.22.0 to 10.24.2 Xcaciv/appsec-test-2024#3

Open

dwhiteGUK mentioned this pull request Oct 28, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.24.2 dwhiteGUK/dlw.dev#39

Closed

X-oss-byte mentioned this pull request Nov 8, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.24.3 X-oss-byte/next-auth#130

Open

Uh oh!

fix(hydration): streaming renders #4446

fix(hydration): streaming renders #4446

Uh oh!

Conversation

JoviDeCroock commented Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

duration

usedJSHeapSize

Results

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

run-warmup-0

run-warmup-1

run-warmup-2

run-warmup-3

run-warmup-4

run-final

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

Uh oh!

github-actions bot commented Jul 16, 2024

Uh oh!

coveralls commented Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JoviDeCroock commented Jul 16, 2024 •

edited

Loading

github-actions bot commented Jul 16, 2024 •

edited

Loading

coveralls commented Jul 16, 2024 •

edited

Loading