Skip to content

Conversation

@hamza0867
Copy link
Contributor

This PR adds missing types in compat:

  • ElementType
  • ComponentPropsWithoutRef

The implementation is taken directly from react's types.

This change is needed to get correct types when using Radix UI with react

@coveralls
Copy link

Coverage Status

coverage: 99.61%. remained the same
when pulling 3cf39b0 on hamza0867:main
into 82ab555 on preactjs:main.

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rschristian rschristian merged commit db0f4f2 into preactjs:main Jul 6, 2024
@coveralls
Copy link

Coverage Status

coverage: 99.61%. remained the same
when pulling 212b17a on hamza0867:main
into 82ab555 on preactjs:main.

@JoviDeCroock JoviDeCroock mentioned this pull request Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants