Skip to content

fix: onSubmit event type #4220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2023
Merged

fix: onSubmit event type #4220

merged 1 commit into from
Nov 27, 2023

Conversation

@marvinhagemeister
Copy link
Member

@marvinhagemeister marvinhagemeister commented Nov 27, 2023

The submit event dispatches a SubmitEvent class, not just Event. See https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormElement/submit_event

@coveralls
Copy link

coveralls commented Nov 27, 2023 •
edited
Loading

Coverage Status

coverage: 99.463%. remained the same
when pulling 4b343dc on fix-submit-type
into 3b7d7c0 on main.

lucacasonato
lucacasonato approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@lucacasonato lucacasonato left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ This makes my life so much better :)

@marvinhagemeister marvinhagemeister merged commit 3eb790c into main Nov 27, 2023
@marvinhagemeister marvinhagemeister deleted the fix-submit-type branch November 27, 2023 15:52
This was referenced Dec 7, 2023
Merged
Merged
@X-oss-byte X-oss-byte mentioned this pull request May 21, 2024
Open
@q1blue q1blue mentioned this pull request May 24, 2024
Open
@Leeze555 Leeze555 mentioned this pull request May 31, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Jun 5, 2024
Open
This was referenced Jun 15, 2024
Open
Open
Open
@vAHiD55555 vAHiD55555 mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

+1 more reviewer

@lucacasonato lucacasonato lucacasonato approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

types

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marvinhagemeister @coveralls @lucacasonato @JoviDeCroock