Skip to content

[Alpha WIP] Open Factory SqliteConnections #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 4, 2024
Merged

[Alpha WIP] Open Factory SqliteConnections #30

merged 10 commits into from
Mar 4, 2024

Conversation

stevensJourney
Copy link
Contributor

Work done:

  • Added platforms to pubspec.yaml to indicate web support
  • Added openConnection to SqliteOpenFactory. This allows the open factory to directly create SqliteConnections. This is aligns both native and web connection creation - due to web not having direct access to CommonDatabase in the web worker.
  • Removed isolateConnectionFactory for web databases.

rkistner
rkistner reviewed Feb 20, 2024
View reviewed changes
rkistner
rkistner reviewed Feb 20, 2024
View reviewed changes
@stevensJourney stevensJourney marked this pull request as ready for review March 4, 2024 15:34
@stevensJourney stevensJourney merged commit 79b0ff9 into alpha-web-prerelease Mar 4, 2024
@stevensJourney stevensJourney deleted the web-alpha-2 branch March 4, 2024 15:34
@stevensJourney stevensJourney mentioned this pull request Mar 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkistner rkistner rkistner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevensJourney @rkistner