Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/powersync_core/lib/src/sync/streaming_sync.dart
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,8 @@ class StreamingSyncImplementation implements StreamingSync {
}
final uri = credentials.endpointUri('sync/stream');

final request = http.Request('POST', uri);
final request =
http.AbortableRequest('POST', uri, abortTrigger: _abort!.onAbort);
request.headers['Content-Type'] = 'application/json';
request.headers['Authorization'] = "Token ${credentials.token}";
request.headers['Accept'] =
Expand Down
2 changes: 1 addition & 1 deletion packages/powersync_core/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ dependencies:
sqlite3_web: ^0.3.2
universal_io: ^2.0.0
meta: ^1.0.0
http: ^1.4.0
http: ^1.5.0
uuid: ^4.2.0
async: ^2.10.0
logging: ^1.1.1
Expand Down
44 changes: 43 additions & 1 deletion packages/powersync_core/test/in_memory_sync_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import 'package:powersync_core/powersync_core.dart';
import 'package:powersync_core/sqlite3_common.dart';
import 'package:powersync_core/src/sync/streaming_sync.dart';
import 'package:powersync_core/src/sync/protocol.dart';
import 'package:shelf/shelf.dart';
import 'package:shelf_router/shelf_router.dart';
import 'package:test/test.dart';

import 'bucket_storage_test.dart';
Expand Down Expand Up @@ -63,7 +65,7 @@ void _declareTests(String name, SyncOptions options, bool bson) {

void createSyncClient({Schema? schema}) {
final (client, server) = inMemoryServer();
server.mount(syncService.router.call);
server.mount((req) => syncService.router(req));

final thisSyncClient = syncClient = database.connectWithMockService(
client,
Expand Down Expand Up @@ -937,6 +939,46 @@ void _declareTests(String name, SyncOptions options, bool bson) {

expect(await query.next, 'from server');
});

group('abort', () {
test('during connect', () async {
final requestStarted = Completer<void>();

syncService.router = Router()
..post('/sync/stream', expectAsync1((Request request) async {
requestStarted.complete();

// emulate a network that never connects
await Completer<void>().future;
}));

syncClient.streamingSync();
await requestStarted.future;
expect(database.currentStatus, isSyncStatus(connecting: true));

await syncClient.abort();
expect(database.currentStatus.anyError, isNull);
});

test('during stream', () async {
final status = await waitForConnection();
syncService.addLine({
'checkpoint': {
'last_op_id': '0',
'buckets': [
{
'bucket': 'bkt',
'checksum': 0,
}
],
},
});
await expectLater(status, emits(isSyncStatus(downloading: true)));

await syncClient.abort();
expect(database.currentStatus.anyError, isNull);
});
});
});
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ final class MockSyncService {
StreamController();
Completer<Request> _listener = Completer();

final router = Router();
var router = Router();
Object? Function() writeCheckpoint = () {
return {
'data': {'write_checkpoint': '10'}
Expand Down
49 changes: 47 additions & 2 deletions packages/powersync_core/test/utils/in_memory_http.dart
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,29 @@ final class _MockServer implements shelf.Server {

Future<StreamedResponse> handleRequest(
BaseRequest request, ByteStream body) async {
final cancellationFuture = switch (request) {
Abortable(:final abortTrigger) => abortTrigger,
_ => null,
};

if (_handler case final endpoint?) {
final shelfRequest = shelf.Request(
request.method,
request.url,
headers: request.headers,
body: body,
);
final shelfResponse = await endpoint(shelfRequest);

final shelfResponse = await Future.any<shelf.Response>([
Future.sync(() => endpoint(shelfRequest)),
if (cancellationFuture != null)
cancellationFuture.then((_) {
throw RequestAbortedException();
}),
]);

return StreamedResponse(
shelfResponse.read(),
shelfResponse.read().injectCancellation(cancellationFuture),
shelfResponse.statusCode,
headers: shelfResponse.headers,
);
Expand All @@ -54,3 +66,36 @@ final class _MockServer implements shelf.Server {
}
}
}

extension<T> on Stream<T> {
Stream<T> injectCancellation(Future<void>? token) {
if (token == null) {
return this;
}

return Stream.multi(
(listener) {
final subscription = listen(
listener.addSync,
onError: listener.addErrorSync,
onDone: listener.closeSync,
);

listener
..onPause = subscription.pause
..onResume = subscription.resume
..onCancel = subscription.cancel;

token.whenComplete(() {
if (!listener.isClosed) {
listener
..addErrorSync(RequestAbortedException())
..closeSync();
subscription.cancel();
}
});
},
isBroadcast: isBroadcast,
);
}
}
Loading