Skip to content

Conversation

stevensJourney
Copy link
Contributor

@stevensJourney stevensJourney commented Sep 16, 2025

Overview

This is a minor followup to #74.

This:

  • Adds a changelog entry
  • Adds a unit test for updated local_uris
  • Adds a waitForInit method which reports once the automatically triggered verification is completed. We use some Combine APIs which are only available in MacOS 12 and iOS15 - this then updates our minimum target in order to support this. MacOsS11 reached end of support on 26 September 2023 Source. iOS14 reached end of support at a 20 Sep 2021 Source.

simolus3
simolus3 previously approved these changes Sep 16, 2025
Copy link
Contributor

@simolus3 simolus3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with these changes 👍

@stevensJourney stevensJourney marked this pull request as ready for review September 19, 2025 08:02
simolus3
simolus3 previously approved these changes Sep 19, 2025
Copy link
Contributor

@simolus3 simolus3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final nit 😬

@simolus3 simolus3 merged commit 08fd253 into main Sep 19, 2025
4 checks passed
@simolus3 simolus3 deleted the attachment_local_uris branch September 19, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants