Encryption part 1: Restructure SDK modules #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevensJourney
approved these changes
Oct 22, 2025
| - `commonJava` - Shared logic for Android and Java targets. | ||
| - `androidMain` - Android-specific code for loading the core extension. | ||
| - `jvmMain` - Java-specific code for loading the core extension. | ||
| - `nativeMain` - A SQLite driver implemented with cinterop calls to sqlite3. |
There was a problem hiding this comment.
There are also some other folders like appleMain and appleNonWatchOsMain in here. Might be worth mentioning.
| } | ||
| } | ||
|
|
||
| cinterops.create("sqlite3") { |
There was a problem hiding this comment.
Just for my clarification. We aren't linking SQLite in Common, but we're just declaring the interop headers which will be linked later?
| * params = params | ||
| * ) | ||
| * ``` | ||
| * TODO: Internal Team - Status changes are reported on [statusStream]. |
There was a problem hiding this comment.
I'm actually not sure what this TODO was for. We should probably remove this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
:corehas build logic ensuring a copy of SQLite is bundled with all apps depending on it. That's usually what we want because the SQLite build from operating systems is either unavailable (Android) or outdated / missing extension support (Apple).However, it also means that the SQLite library can't be customized. This is an issue for users wanting to use say SQLCipher. As a first step towards that, this:
:common(really unfortunate that:corewas taken :D) project containg virtually all sources and tests that currently live in:core. The only difference is that this project doesn't depend onsqlite-bundledor the:static-sqlite-driver.:coreto mostly be an empty shell depending on:commonand the bundled SQLite dependencies.:commonto depend on:coreand bundled SQLite in its tests only.The idea is that users not wanting to depend on the regular SQLite build could customize things by depending on
:commoninstead.