-
Notifications
You must be signed in to change notification settings - Fork 18
Fix some logging issues #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
68f8f4c
Do not modify global Kermit severity
Radiokot 53739f7
Add 'PowerSync' tag for the logs
Radiokot 535f107
Get rid of generateLogger()
Radiokot 95f01c1
Fix lint issues
Radiokot 287a337
Apply format
simolus3 14dfd40
Revert "Get rid of generateLogger()"
Radiokot fe1eaea
Update core/src/commonMain/kotlin/com/powersync/utils/Log.kt
stevensJourney c5aaab8
Merge branch 'main' into fix/logging
Radiokot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,28 @@ | ||
package com.powersync.utils | ||
|
||
import BuildConfig | ||
import co.touchlab.kermit.Logger | ||
import co.touchlab.kermit.Severity | ||
import co.touchlab.kermit.StaticConfig | ||
import co.touchlab.kermit.platformLogWriter | ||
|
||
/* | ||
* Generates a logger with the appropriate severity level based on the build type | ||
* if no Logger is provided. | ||
*/ | ||
public fun generateLogger(logger: Logger?): Logger { | ||
if (logger != null) { | ||
return logger | ||
} | ||
|
||
val defaultLogger: Logger = Logger | ||
|
||
if (BuildConfig.isDebug) { | ||
Logger.setMinSeverity(Severity.Verbose) | ||
} else { | ||
Logger.setMinSeverity(Severity.Warn) | ||
} | ||
|
||
return defaultLogger | ||
} | ||
public fun generateLogger(logger: Logger?): Logger = | ||
logger | ||
?: Logger( | ||
config = | ||
StaticConfig( | ||
logWriterList = | ||
listOf(platformLogWriter()), | ||
minSeverity = | ||
if (BuildConfig.isDebug) { | ||
Severity.Verbose | ||
} else { | ||
Severity.Warn | ||
}, | ||
), | ||
tag = "PowerSync", | ||
) | ||
stevensJourney marked this conversation as resolved.
Show resolved
Hide resolved
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.