Make urls in the Links header clickable. #795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngbrown
force-pushed
the
dev-header-links
branch
from
dfc7f85 to
6aff985
Compare
ngbrown
force-pushed
the
dev-header-links
branch
from
6aff985 to
0fe3861
Compare
|
I emailed @a85 awhile ago about hyperlinking the RFC 5988 links, and he replied that it was on the todo list, but I figured out how to implement it in this pull request. If this patch is accepted, does it make its way to the packaged app? There are things in that that work better (like the collections). Thanks |
|
@ngbrown We try to merge patches from the legacy app into the packaged app too. @abhijitkane Can you look into this too? We can push this in the weekend release. |
|
I've added this to the main repo. |
abhijitkane
added a commit
that referenced
this pull request
Nov 26, 2014
Make urls in the Links header clickable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will partially parse the Link header (RFC 5988) and make the URLs clickable and load as a new request.