Skip to content

Conversation

dura0ok
Copy link

@dura0ok dura0ok commented Aug 4, 2023

No description provided.

@dura0ok dura0ok force-pushed the fix-compiler-warnings branch from 18f7b6e to cbf89a8 Compare August 4, 2023 22:07
Copy link
Contributor

@esabol esabol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you, @stepan-neretin7 !

Copy link
Contributor

@vitcpp vitcpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I'm ok with the fix. One trivial concern is the chosen variable name, but I do not see the sense in asking authors about it. It may be easily changed in the future.

@vitcpp vitcpp merged commit 04456c7 into postgrespro:master Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants