Some typing fixes #581
Merged
Some typing fixes #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wch
commented
Apr 12, 2024
rsconnect/main.py
Outdated
Comment on lines
2213
to
2214
| if not isinstance(ce.remote_server, RSConnectServer): | ||
| raise RSConnectException("This command requires a Posit Connect server.") |
Collaborator
Author
There was a problem hiding this comment.
I used a pretty generic exception message here, but am willing to customize it for each command, if you think that would help.
For example, in this case, it could be:
"`rsconnect content describe` requires a Posit Connect server."
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
wch
commented
Apr 12, 2024
| @wraps(func) | ||
| def wrapper(*args: P.args, **kwargs: P.kwargs): | ||
| def failed(err: str): | ||
| def failed(err: str) -> Never: |
Collaborator
Author
There was a problem hiding this comment.
The explicit Never return helps pyright recognize that the calls to failed() will never return.
mmarchetti
approved these changes
Apr 12, 2024
Contributor
mmarchetti
left a comment
mmarchetti
left a comment
There was a problem hiding this comment.
I'm OK with the more generic messages, but the specific ones would be a nice touch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some typing fixes, and also adds some runtime checks that
ce.remote_serveris aRSConnectServer.