Skip to content

Conversation

@aronatkins
Copy link
Collaborator

Intent

fixes #534

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change

Approach

Port the changes from #254 into write_quarto_manifest_json()

Automated Tests

Directions for Reviewers

Checklist

  • I have updated CHANGELOG.md to cover notable changes.
  • I have updated all related GitHub issues to reflect their current state.

@github-actions
Copy link

github-actions bot commented Jan 16, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4421 3146 71% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/actions.py 35% 🟢
rsconnect/bundle.py 80% 🟢
TOTAL 57% 🟢

updated for commit: 1d23067 by action🐍



def write_quarto_manifest_json(
directory: str,
Copy link
Contributor

@toph-allen toph-allen Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know naming probably isn't in scope for feedback, but this name directory was changed to file_or_directory. The name path would also work; it implies file_or_directory nicely. Feel free to disregard. (I know we already used file_or_directory before, and perhaps widely in rsconnect-python, so if this is a settled issue, definitely disregard ☺️)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an existing name and used as the argument name for rsconnect write-manifest quarto and rsconnect deploy quarto. We used that name to make it clearer that the target could be either a directory or a single file. This was different from the other commands at the time.

@aronatkins
Copy link
Collaborator Author

Tested manifest creation and deployment with this change:

Quarto documents (with and without Python requirements)

rsconnect write-manifest quarto index.qmd
rsconnect deploy quarto index.qmd

Quarto projects (with and without Python requirements)

rsconnect write-manifest quarto .
rsconnect deploy quarto .

@aronatkins aronatkins merged commit 55a730d into master Jan 19, 2024
@aronatkins aronatkins deleted the aron-issue-534 branch January 19, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quarto: write-manifest with a Quarto file cannot locate manifest.json

4 participants