Skip to content

Conversation

@mmarchetti
Copy link
Contributor

This PR fixes Snyk CI based on our move to pyproject.toml.

Intent

Snyk doesn't support analyzing Python dependencies from pyproject.toml unless the project uses Poetry. This PR creates a requirements.txt file listing the dependencies from pyproject.toml, and removes the analysis of setup.py which no longer contains dependency information.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change

Approach

Automated Tests

Directions for Reviewers

Checklist

  • I have updated CHANGELOG.md to cover notable changes.
  • I have updated all related GitHub issues to reflect their current state.

@github-actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4231 2775 66% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: b75e305 by action🐍

Copy link
Collaborator

@tdstein tdstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bummer. Would a direct reference to the built distribution be a workaround?

https://peps.python.org/pep-0440/#direct-references

@mmarchetti mmarchetti merged commit 175a4c3 into master Oct 23, 2023
@mmarchetti mmarchetti deleted the mm-snyk branch October 23, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants