-
Notifications
You must be signed in to change notification settings - Fork 116
Rename suspend_display() to hide()
#996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To avoid this connotation, I was thinking of proposing |
|
Maybe we could hang this decorator and |
|
Just want to state for the record that I'd like this to work (especially if we use the name "hold"): with hide() as held:
@render.text()
def txt2():
return "Text here"
held |
|
Closing in favor of #1037. |
This PR renames
suspend_displaytohide. The old name feels very advanced, and it also sounds imperative and stateful, and it refers to a state that most users don't really need to understand and could be confusing. For example, a user might thing, "OK, so we were displaying before, but now we're suspending it... and then how do I resume it?"Here are some examples of usage:
With
hide(), it's a bit less confusing:One possibly confusing thing about using
hideorhiddenis that it might suggest to the user that therendered content won't be shown at all, when in fact it will be shown where the correspondingoutput_*()function is used.