Skip to content

Fix failing deploy tests #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Fix failing deploy tests #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6760d93
use `navset_card` instead of `navset_card_tab` for shiny express
karangattu Dec 19, 2023
a131966
Fix failing deploy tests
karangattu Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/playwright/deploys/apps/plotly_app/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
pandas
plotly
git+https://github.com/posit-dev/py-shiny.git#egg=shiny
git+https://github.com/posit-dev/py-htmltools#egg=htmltools
git+https://github.com/posit-dev/py-shinywidgets#egg=shinywidgets
git+https://github.com/posit-dev/py-htmltools.git#egg=htmltools
git+https://github.com/posit-dev/py-shinywidgets.git#egg=shinywidgets
2 changes: 1 addition & 1 deletion tests/playwright/deploys/apps/shiny-express-accordion/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
git+https://github.com/posit-dev/py-shiny.git#egg=shiny
git+https://github.com/posit-dev/py-htmltools#egg=htmltools
git+https://github.com/posit-dev/py-htmltools.git#egg=htmltools
10 changes: 4 additions & 6 deletions tests/playwright/deploys/apps/shiny-express-page-default/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
background-color: #00000022}
"""
)


with layout.div(id="shell"):
with layout.row():
with layout.column(width=8):
Expand All @@ -30,20 +28,20 @@

with layout.column(width=6):
# check height is below 300px - bounding box
with layout.navset_card_tab(id="express_navset_card_tab"):
with layout.nav(title="Two"):
with layout.navset_card(id="express_navset_card_tab", type="tab"):
with layout.nav_panel(title="Two"):
...


with layout.column(width=6):
with layout.row():
with layout.navset_tab(id="express_navset_tab"):
with layout.navset(id="express_navset_tab", type="tab"):
for fn_txt, fn in [
("pre", layout.pre),
("div", layout.div),
("span", layout.span),
]:
with layout.nav(title=fn_txt):
with layout.nav_panel(title=fn_txt):
for i in range(3):
with fn():
ui.HTML(f"{fn_txt} {i}")
2 changes: 1 addition & 1 deletion tests/playwright/deploys/apps/shiny-express-page-default/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
git+https://github.com/posit-dev/py-shiny.git#egg=shiny
git+https://github.com/posit-dev/py-htmltools#egg=htmltools
git+https://github.com/posit-dev/py-htmltools.git#egg=htmltools
2 changes: 1 addition & 1 deletion tests/playwright/deploys/apps/shiny-express-page-fillable/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
git+https://github.com/posit-dev/py-shiny.git#egg=shiny
git+https://github.com/posit-dev/py-htmltools#egg=htmltools
git+https://github.com/posit-dev/py-htmltools.git#egg=htmltools
2 changes: 1 addition & 1 deletion tests/playwright/deploys/apps/shiny-express-page-fluid/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
git+https://github.com/posit-dev/py-shiny.git#egg=shiny
git+https://github.com/posit-dev/py-htmltools#egg=htmltools
git+https://github.com/posit-dev/py-htmltools.git#egg=htmltools
2 changes: 1 addition & 1 deletion tests/playwright/deploys/apps/shiny-express-page-sidebar/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
git+https://github.com/posit-dev/py-shiny.git#egg=shiny
git+https://github.com/posit-dev/py-htmltools#egg=htmltools
git+https://github.com/posit-dev/py-htmltools.git#egg=htmltools