-
Notifications
You must be signed in to change notification settings - Fork 116
feat: Add ui.layout_columns()
#856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
ae514d1
use latest bslib with layout columns custom element
gadenbuie 1fe3ee0
feat(layout_columns): Works and accepts `col_widths`
gadenbuie 2f48831
feat(layout_columns): Support scalar integer for breakpoint
gadenbuie b154a26
feat(layout_columns): Support `row_heights` argument
gadenbuie 57560fd
chore: Consolidate types
gadenbuie 7c5116b
feat(layout_columns): Wrap children in .bslib-grid-item containers
gadenbuie 42a7198
chore: Rename `ui.layout_columns_grid()`
gadenbuie fb3c9bd
feat: If singular `row_heights`, use value across all breakpoints
gadenbuie 8713948
chore: Update bslib components.css
gadenbuie bf2e0d0
chore: make the formatters happy
gadenbuie 9a797b7
refactor: row_heights code review
gadenbuie b08dc00
Merge remote-tracking branch 'origin/main' into feat/layout-columns-grid
gadenbuie 3813018
rename: as_col_spec() and use intermediate object for happier pyright
gadenbuie ec09614
rename BreakpointsOptional type
gadenbuie 2fb6f58
validate input to get down to one cast() call
gadenbuie 7a6b70d
chore: update bslib deps again
gadenbuie 3f8061e
feat: write col-widths-{break} attributes
gadenbuie d14912b
express: Add layout_columns_grid()
gadenbuie 85c4c53
rename back to layout_columns
gadenbuie 3510943
update bslib dependency
gadenbuie e2e521d
remove use of json module
gadenbuie 7403ce6
docs(layout_columns): Document `layout_columns()`
gadenbuie 2233d1c
Merge branch 'main' into feat/layout-columns-grid
gadenbuie c9b13ad
chore: remove unused import from example
gadenbuie eee050e
fix: Fix exporting of `layout_columns()` from `ui`
gadenbuie c693b65
Merge branch 'main' into feat/layout-columns-grid
gadenbuie 5401af4
chore: update bslib deps
gadenbuie 24a6cb5
avoid problematic type check for Python 3.9
gadenbuie 3bc470f
chore: remove unused things
gadenbuie 1e1f9c1
remove default page from express layout_columns
gadenbuie 338f33f
relocate `as_col_spec()` and use Enum for breakpoints
gadenbuie 8c36832
remove example app for now
gadenbuie 67b0e0b
Merged origin/main into feat/layout-columns-grid
gadenbuie a646a11
remove newlines between parameter docs
gadenbuie eb5afc1
docs: Add item to changelog
gadenbuie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.