Skip to content

Make flaky dataframe test have larger timeout #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Make flaky dataframe test have larger timeout #675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion e2e/data_frame/test_data_frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,19 @@ def test_sort(
select_dataset.set("diamonds")
select_dataset.expect.to_have_value("diamonds")

# Test sorting
# Table cell locators
header_clarity = grid_container.locator("tr:first-child th:nth-child(4)")
first_cell_clarity = grid_container.locator("tr:first-child td:nth-child(4)")

# Test that the table contents have updated
# This may timeout unless a larger timeout is given
expect(header_clarity).not_to_have_text(
"num2",
timeout=15 * 1000, # Larger timeout for CI
)
expect(first_cell_clarity).not_to_have_text("4")

# Test sorting
expect(first_cell_clarity).to_have_text("SI2")
header_clarity.click()
expect(first_cell_clarity).to_have_text("I1")
Expand Down