Skip to content

Conversation

@schloerke
Copy link
Collaborator

@jcheng5 My questionable change is adding the name to click.group(). Is this an ok change?


pyright
/home/runner/work/py-shiny/py-shiny/shiny/_main.py
  /home/runner/work/py-shiny/py-shiny/shiny/_main.py:24:2 - error: Untyped function decorator obscures type of function; ignoring decorator (reportUntypedFunctionDecorator)
  /home/runner/work/py-shiny/py-shiny/shiny/_main.py:32:7 - error: Cannot access member "command" for type "function"
    Member "command" is unknown (reportFunctionMemberAccess)
  /home/runner/work/py-shiny/py-shiny/shiny/_main.py:370:7 - error: Cannot access member "command" for type "function"
    Member "command" is unknown (reportFunctionMemberAccess)
  /home/runner/work/py-shiny/py-shiny/shiny/_main.py:399:7 - error: Cannot access member "command" for type "function"
    Member "command" is unknown (reportFunctionMemberAccess)
  /home/runner/work/py-shiny/py-shiny/shiny/_main.py:427:7 - error: Cannot access member "command" for type "function"
    Member "command" is unknown (reportFunctionMemberAccess)
5 errors, 0 warnings, 0 informations

cc @karangattu

@schloerke schloerke requested a review from jcheng5 July 7, 2023 20:24
@schloerke
Copy link
Collaborator Author

Test failures for example apps are unrelated to changes. Merging

@schloerke schloerke changed the title bug: Fix typing issues in latest click bug(typing): Fix typing issues in latest click package Jul 10, 2023
@schloerke schloerke merged commit f29d8a2 into main Jul 10, 2023
@schloerke schloerke deleted the main_typing branch July 10, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants