Skip to content

chore: Use np.nan instead of np.NaN #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2024
Merged

chore: Use np.nan instead of np.NaN #1468

merged 3 commits into from
Jun 18, 2024

Conversation

@schloerke
Copy link
Collaborator

@schloerke schloerke commented Jun 18, 2024 •
edited
Loading

Related: numpy/numpy#24376 ; (Removes np.NaN for v2.0.0 release)

Better notes from @wch in #1467

In numpy 2.0, they removed np.NaN. This PR switches to np.nan instead, which is available at least as far back as numpy 1.15, according to the docs.

https://numpy.org/doc/1.15/reference/constants.html#numpy.nan

@schloerke schloerke enabled auto-merge June 18, 2024 15:00
@jcheng5

This comment was marked as resolved.

Sign in to view
@jcheng5

This comment was marked as resolved.

Sign in to view
@schloerke schloerke changed the title chore: Use numpy >= 2.0.0 chore: Use np.nan instead of np.NaN Jun 18, 2024
@schloerke schloerke added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit 9e16208 Jun 18, 2024
@schloerke schloerke deleted the chore/fix-ci branch June 18, 2024 15:20
@schloerke schloerke mentioned this pull request Jun 18, 2024
Closed
schloerke added a commit that referenced this pull request Jun 20, 2024
@schloerke
Merge branch 'main' into chore/unlock-pyright-version
2d06852 
* main:
  Update quartodoc (#1469)
  chore: Use `np.nan` instead of `np.NaN` (#1468)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@schloerke @jcheng5