Skip to content

fix(panel_conditional): Include .shiny-panel-conditional class #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2024
Merged

fix(panel_conditional): Include .shiny-panel-conditional class #1257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95c9af6
fix(panel_conditional): Include `.shiny-panel-conditional` class
gadenbuie Mar 28, 2024
cbd37c0
docs: update changelog
gadenbuie Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

* `ui.layout_columns()` now correctly applies the `row_heights` at the `xs` breakpoint, if supplied. (#1222)

* `ui.panel_conditional()` now adds the `.shiny-panel-conditional` class to the `<div>` element wrapping the conditional panel contents. (#1257)

### Other changes

* The fill CSS used by fillable containers (i.e. when `fillable=True`) now uses a [CSS cascade layer](https://developer.mozilla.org/en-US/docs/Learn/CSS/Building_blocks/Cascade_layers) named `htmltools` to reduce the precedence order of the fill CSS. (#1228)
Expand Down
8 changes: 7 additions & 1 deletion shiny/ui/_bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,13 @@ def panel_conditional(
if ns_prefix != "":
ns_prefix += "-"

return div(*args, data_display_if=condition, data_ns_prefix=ns_prefix, **kwargs)
return div(
*args,
{"class": "shiny-panel-conditional"},
data_display_if=condition,
data_ns_prefix=ns_prefix,
**kwargs,
)


@add_example()
Expand Down