-
Notifications
You must be signed in to change notification settings - Fork 117
feat(card): Report full screen state as a Shiny input #1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
741e265
chore: update bslib dependencies
gadenbuie e17156d
feat(card): Cards and value boxes now take `id` to become shiny inputs
gadenbuie 156ace7
tests(card-inputs): Add tests for the card input value
gadenbuie cf19e5a
chore: fix unused import
gadenbuie 1d47032
chore: Use latest bslib component dependency
gadenbuie bae994a
docs: Add item to changelog
gadenbuie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -104,6 +104,7 @@ def card( | |
| fill=fill, | ||
| class_=class_, | ||
| wrapper=wrapper, | ||
| id=None, | ||
| **kwargs, | ||
| ) | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1134,6 +1134,7 @@ def value_box( | |
| max_height=max_height, | ||
| fill=fill, | ||
| class_=class_, | ||
| id=None, | ||
| **kwargs, | ||
| ) | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| { | ||
| "note!": "This file is auto-generated by scripts/htmlDependencies.R", | ||
| "package": "shiny", | ||
| "version": "Github (rstudio/shiny@6760c318184535185e5050aefe29e658e8710ef0)" | ||
| "version": "Github (rstudio/shiny@e2b7f9113866a2f0a98b0cac240320116c5ff56a)" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| { | ||
| "note!": "This file is auto-generated by scripts/htmlDependencies.R", | ||
| "shiny_version": "Github (rstudio/shiny@6760c318184535185e5050aefe29e658e8710ef0)", | ||
| "bslib_version": "Github (rstudio/bslib@1929f7e63197f6073085a03f926f11829b7292ea)", | ||
| "shiny_version": "Github (rstudio/shiny@e2b7f9113866a2f0a98b0cac240320116c5ff56a)", | ||
| "bslib_version": "Github (rstudio/bslib@8751c7cc1d883f3d04c727e7f0eab89a34f1404c)", | ||
| "htmltools_version": "CRAN (R 4.3.1)", | ||
| "bootstrap_version": "5.3.1" | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, is this needed for this PR? Or just a good idea to do this in general?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanted to make sure we were getting the right fonts since we do some theme re-compilation. I don't think it actually changed any of the files, though so we could take it out. (Or leave it in until the next sass version is released, idk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to leave this in for now. Installing
sasstakes long enough that I'm sure we won't forget to revisit it 😉