Skip to content

Remove asgiref run-time dependency #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Remove asgiref run-time dependency #1183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8913d57
Remove run-time dependency on asgiref
wch Mar 4, 2024
c2c739d
Update changelog
wch Mar 4, 2024
fca472f
Move asgiref back into required
wch Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [UNRELEASED] - YYYY-MM-DD

### Breaking Changes

### New features

### Bug fixes

### Other changes

* Closed #1178: Removed run-time dependency on asgiref. (#1183)

## [0.8.0] - 2024-03-04

Expand Down
23 changes: 12 additions & 11 deletions shiny/_autoreload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,18 @@
import secrets
import threading
import webbrowser
from typing import Callable, Optional, cast

import starlette.types
from asgiref.typing import (
ASGI3Application,
ASGIReceiveCallable,
ASGISendCallable,
ASGISendEvent,
HTTPResponseStartEvent,
Scope,
)
from typing import TYPE_CHECKING, Callable, Optional, cast

if TYPE_CHECKING:
import starlette.types
from asgiref.typing import (
ASGI3Application,
ASGIReceiveCallable,
ASGISendCallable,
ASGISendEvent,
HTTPResponseStartEvent,
Scope,
)

from ._hostenv import get_proxy_url

Expand Down