Skip to content

Conversation

@schloerke
Copy link
Collaborator

Without changes from #1013 , I believe the type checking should be failing. (I'd be happy to be wrong!)

@schloerke schloerke added this to the v0.8.0 milestone Mar 3, 2024
@schloerke
Copy link
Collaborator Author

After running make clean locally, I am not able to reprex the pyright errors associated with starlette 0.37.1.

@wch We might be ok closing this PR and #1013 ?

@schloerke
Copy link
Collaborator Author

Typings work now. I see what you did in #1013 . Thank you.

Closing this PR as it is not needed.

@schloerke schloerke closed this Mar 4, 2024
@schloerke schloerke deleted the ci_install_shiny branch March 4, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants