Restore support for matplotlib<3.6 #1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Retrospectively, this looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #999 depended on matplotlib's layout engine API, which was added in matplotlib 3.6.
Matplotlib is currently on 3.8, so normally this would be OK. However, the version of Pyodide we're using in Shinylive comes with matplotlib 3.5.2, so plots don't work at all on that platform -- it simply throws an error when
fig.get_layout_engine()is called. This PR restores support for older versions of matplotlib.@has2k1 I'm going to merge this soon to get the dev version of shinylive working again, but please take a look at the PR when you have a chance to make sure it looks good.