Skip to content

Conversation

@gadenbuie
Copy link
Contributor

@gadenbuie gadenbuie commented Jan 2, 2024

Updates the site to use the v1.4.533 preview release of Quarto.

This should have a small impact on the site and is worth it for a few reasons:

  1. quarto 1.4 uses Bootstrap 5.3, which is the same version used by py-shiny and bslib.
  2. Bootstrap 5.3 brings sweeping improvements and we should be building on these as much as possible; delaying the update increases the chances of introducing avoidable technical debt in the process. Improvements include wider use of CSS variables and dark mode styles.
  3. There are a number of bugs that will be fixed by 1.4 that we'll be stuck with in 1.3; we're also pushing the envelope of Quarto's capabilities and may discover new bugs in the process (that would only be fixed with 1.4).
    • The biggest bug we have with 1.3 is that EJS templates eat empty new lines, causing the code examples in the components gallery to be smushed together. This is fixed in 1.4.

@github-actions github-actions bot temporarily deployed to pr-55 January 2, 2024 17:21 Destroyed
@gshotwell
Copy link
Contributor

I'm not against this, but for posterity what do we need from the dev version?

@github-actions github-actions bot temporarily deployed to pr-55 January 3, 2024 21:26 Destroyed
@gadenbuie
Copy link
Contributor Author

@gshotwell I updated the OP to describe what we get from this. Also #53 is dependent on this PR.

@gshotwell @gregswinehart I've looked through a selection of pages and fixed anything I noticed, most of which I found in the components gallery. Let me know if you see anything and I'll be happy to tweak or address.

@gshotwell gshotwell merged commit 7d3e006 into main Jan 4, 2024
@gshotwell gshotwell deleted the quarto/use-v1-4 branch January 4, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants