Skip to content

reactive-mutable: tweak problem/solution examples #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 24, 2024
Merged

reactive-mutable: tweak problem/solution examples #151

merged 4 commits into from
May 24, 2024

Conversation

@gadenbuie
Copy link
Contributor

@gadenbuie gadenbuie commented May 24, 2024 •
edited
Loading

Updates the problem/solution examples in the reative-mutable article.

  1. I put the problem/solution examples in callouts so that it's visually clear which one provides the pattern to follow.
  2. Small edit to make it easier to see the problem with the leaky changes example
  3. Use @render.code instead of @render.text and change "raw values" to "user values" to make it easier to read.
  4. Added a section on python operations that create copies.

Preview: https://pr-151--pyshiny.netlify.app/docs/reactive-mutable.html

@gadenbuie gadenbuie requested review from cpsievert and wch May 24, 2024 15:15
@github-actions github-actions bot temporarily deployed to pr-151 May 24, 2024 15:30 Destroyed
@github-actions github-actions bot temporarily deployed to pr-151 May 24, 2024 15:44 Destroyed
wch
wch approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@wch wch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@wch wch merged commit e986efe into main May 24, 2024
@wch wch deleted the edit/reactive-mutable branch May 24, 2024 16:31
schloerke added a commit that referenced this pull request Jul 17, 2024
@schloerke
Merge branch 'main' into rename_df_input_cell_selection
25e0178 
* main:
  feat: Enable repo-actions (#175)
  Fix link to shinylive examples (#174)
  Abstract out express_core_preview() internals into a app_preview_code() helper so that shiny-dev-center can use it (#172)
  #155 update id (#170)
  Update Quarto to 1.4.557 (#169)
  Add deployment overview doc (#166)
  fix database-explorer preview image
  reubuild docs with latest py-htmltools (#164)
  Follow up to #159: auto-detect language in append_shinylive_chunk() (#161)
  Update shinylive helpers to better support R (#159)
  Enable fast mode (#157)
  Disable busy indication in static previews (#156)
  QA fixes for components/templates (#150)
  Update shiny and shinylive (#154)
  Update shiny-vscode link (#153)
  reactive-mutable: tweak problem/solution examples (#151)
  Update py-shiny and py-shinylive (#149)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wch wch wch approved these changes

@cpsievert cpsievert Awaiting requested review from cpsievert

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gadenbuie @wch