Skip to content

Conversation

@toph-allen
Copy link
Collaborator

@toph-allen toph-allen commented Jan 6, 2025

Related to #352 (does not close)

Outstanding problems

  • codecov.io needs to be set up with the new URL (1, 2)
  • Some tests are failing with the new URLs: Query params to repo_branches, Query params to repo_manifest_dirs
  • Possibly remove issue links from NEWS.md

@toph-allen toph-allen linked an issue Jan 6, 2025 that may be closed by this pull request
NEWS.md Outdated
than removing the tag entirely. (#194)
- `audit_r_versions()` returns a bar chart instead of a histogram (#179)
- Fix issue with `NULL` or `length 1` job outputs ([#193](https://github.com/rstudio/connectapi/issues/193))
- Fix issue with `NULL` or `length 1` job outputs ([#193](https://github.com/posit-dev/connectapi/issues/193))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool but we could just remove these links, right? They aren't consistently present, and pkgdown will insert them anyway. (Though I recognize that that's probably not worth the effort to do, this is fine.)

[![CRAN status](https://www.r-pkg.org/badges/version/connectapi)](https://cran.r-project.org/package=connectapi)
[![Codecov test coverage](https://codecov.io/gh/rstudio/connectapi/branch/main/graph/badge.svg)](https://app.codecov.io/gh/rstudio/connectapi?branch=main)
[![R build status](https://github.com/rstudio/connectapi/workflows/R-CMD-check/badge.svg)](https://github.com/rstudio/connectapi/actions)
[![Codecov test coverage](https://codecov.io/gh/posit-dev/connectapi/branch/main/graph/badge.svg)](https://app.codecov.io/gh/posit-dev/connectapi?branch=main)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like codecov needs a new token set up for the repo on posit-dev, or some other way to let them know that the repo has moved--this link doesn't work currently. I think you should be able to set this up but LMK if you can't.

status](https://www.r-pkg.org/badges/version/connectapi)](https://cran.r-project.org/package=connectapi)
[![Codecov test
coverage](https://codecov.io/gh/rstudio/connectapi/branch/main/graph/badge.svg)](https://app.codecov.io/gh/rstudio/connectapi?branch=main)
coverage](https://codecov.io/gh/posit-dev/connectapi/branch/main/graph/badge.svg)](https://app.codecov.io/gh/posit-dev/connectapi?branch=main)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. CRAN will flag this as a bad link if we release with this in like this. (Though I've generally been removing the badge links from the readme when I submit packages to CRAN, it's not helpful on their version of the docs and they so often lead to URL check failures.)

@toph-allen
Copy link
Collaborator Author

@nealrichardson Some of the GitHub tests are also failing with updated URLs in the posit-dev version of the repo. I'll add a checklist to the PR comment up top to track those tasks and the codecov token stuff.

@nealrichardson
Copy link
Collaborator

@nealrichardson Some of the GitHub tests are also failing with updated URLs in the posit-dev version of the repo. I'll add a checklist to the PR comment up top to track those tasks and the codecov token stuff.

Ah right, you need to also find and replace the url-encoded versions in the tests, like https://connect.example/__api__/repo/branches?url=https%3A%2F%2Fgithub.202132.xyz%2Fposit-dev%2Fconnectapi

@toph-allen
Copy link
Collaborator Author

All remaining loose ends have been tied up so I'm gonna merge this.

@toph-allen toph-allen merged commit c7d59b8 into main Jan 7, 2025
19 checks passed
@toph-allen toph-allen deleted the toph/org-update branch January 7, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move repository to posit-dev organization

3 participants