-
Notifications
You must be signed in to change notification settings - Fork 26
chore: change rstudio/connectapi to posit-dev/connectapi #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
NEWS.md
Outdated
| than removing the tag entirely. (#194) | ||
| - `audit_r_versions()` returns a bar chart instead of a histogram (#179) | ||
| - Fix issue with `NULL` or `length 1` job outputs ([#193](https://github.com/rstudio/connectapi/issues/193)) | ||
| - Fix issue with `NULL` or `length 1` job outputs ([#193](https://github.com/posit-dev/connectapi/issues/193)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool but we could just remove these links, right? They aren't consistently present, and pkgdown will insert them anyway. (Though I recognize that that's probably not worth the effort to do, this is fine.)
| [](https://cran.r-project.org/package=connectapi) | ||
| [](https://app.codecov.io/gh/rstudio/connectapi?branch=main) | ||
| [](https://github.com/rstudio/connectapi/actions) | ||
| [](https://app.codecov.io/gh/posit-dev/connectapi?branch=main) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like codecov needs a new token set up for the repo on posit-dev, or some other way to let them know that the repo has moved--this link doesn't work currently. I think you should be able to set this up but LMK if you can't.
| status](https://www.r-pkg.org/badges/version/connectapi)](https://cran.r-project.org/package=connectapi) | ||
| [](https://app.codecov.io/gh/rstudio/connectapi?branch=main) | ||
| coverage](https://codecov.io/gh/posit-dev/connectapi/branch/main/graph/badge.svg)](https://app.codecov.io/gh/posit-dev/connectapi?branch=main) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above. CRAN will flag this as a bad link if we release with this in like this. (Though I've generally been removing the badge links from the readme when I submit packages to CRAN, it's not helpful on their version of the docs and they so often lead to URL check failures.)
|
@nealrichardson Some of the GitHub tests are also failing with updated URLs in the posit-dev version of the repo. I'll add a checklist to the PR comment up top to track those tasks and the codecov token stuff. |
Ah right, you need to also find and replace the url-encoded versions in the tests, like |
|
All remaining loose ends have been tied up so I'm gonna merge this. |
Related to #352 (does not close)
Outstanding problems
Query params to repo_branches,Query params to repo_manifest_dirs