-
Notifications
You must be signed in to change notification settings - Fork 3
refactor(app-canary): monitor only a single GUID #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…llout box instead of displaying in the table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a somewhat fast review. The code looks understandable. I published the bundle and pointed it at a broken application, and got the expected email. Looks good. And managing only a single variable is much easier.
show_instructions = True | ||
instructions.append(f"CANARY_GUIDS environment variable is set but is empty or contains only whitespace. It should be a comma separated list of GUID you wish to monitor. Raw CANARY_GUIDS value: '{canary_guids_str}'") | ||
instruction = f"Please set the <b>{var_name}</b> environment variable and re-render the report." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the final version maybe we wanna tell them where to click to re-render? I mean, maybe they know, but maybe a screenshot of the button. ¯_(ツ)_/¯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a strong feeling about this? I am assuming that if someone has published something to Connect they know how to re-render? I'm noting that the Posit Connect UI button tooltip is Refresh Report
and I'm not quickly finding anything in the Posit Connect User Guide that seems to document that process. Regardless, there could be a language/wording mismatch here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change this wording in a follow-on PR.
Refactor includes:
This is deployed on our internal Connect server: https://dogfood.team.pct.posit.it/connect/#/apps/54e4557b-812d-4f70-afc6-9f2e5022a179/environment
Fixes https://github.com/posit-dev/connect/issues/32394
Fixes https://github.com/posit-dev/connect/issues/32404
Tests
Required env var not set.

Invalid GUID set

Valid GUID, owner of content, content passes validation

Valid GUID, collaborator of content, content passes validation

Valid GUID, viewer of content, content passes validation

Vaid GUID, no permission to content

Valid GUID, owner of content, content fails validation
