-
Notifications
You must be signed in to change notification settings - Fork 3
Azure OpenAI OAuth - R Shiny chat app #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Overall, great work! Some comments of things that may need some clarification or tweaking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way similar to the Usage Metrics Dashboard extension for us to help users setup an Azure OpenAI integration if they already have one? Rather than just linking to the docs we could call the APIs and present a button to auto-add it (if available).
I have some questions around some internal notes and settings for this piece of content. Should this be a Gallery item?
"tags": ["r", "shiny"], | ||
"minimumConnectVersion": "2025.06.0", | ||
"requiredFeatures": ["OAuth Integrations"], | ||
"version": "0.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you looking to release this in a follow-up PR?
Either way you may want to consider adding this extension to the GitHub workflows for the repo so it can be released, gets linted, tested for deployment, etc. The details for this are in the CONTRIBUTING guide, and I'd be happy to answer any questions you have with that process.
"description": "An R Shiny app with an Azure OpenAI OAuth Integration that answers questions about the Palmer Penguins dataset", | ||
"homepage": "https://github.com/posit-dev/connect-extensions/tree/main/extensions/azure-openai-oauth-rshiny", | ||
"category": "example", | ||
"tags": ["r", "shiny"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There currently are no valid tags yet. This feature works, but we haven't decided on tags for the Gallery. Linting with the GitHub workflow setup will catch this.
deployment_id = "gpt-4o-mini", | ||
api_version = "2024-12-01-preview", | ||
endpoint = "https://8ul4l3wq0g.openai.azure.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on @mconflitti-pbc's question this also seems specific to the Posit organization, and not something we can add to the Gallery generally for others to use since you cannot change Gallery content prior to publishing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I totally agree with @mconflitti-pbc and your concerns on this. I was doing this work to fulfill a ticket (https://github.com/posit-dev/connect/issues/31840), but I agree that there probably needs to be a larger discussion about whether it's suited to be a gallery app (@zackverham @christierney). The non-generic api endpoint along with all of the particular data action roles that need to be assigned by an azure administrator make it feel out of place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to mark this as "request changes" to answer the question about this being a gallery item if it cannot be used by others.
@dotNomad I'm going to work on writing more extensive configuration instructions in the readme for this app and for #223 like we talked about earlier this week. I'm also marking them as drafts since all of this work is still very much in progress. Does that make sense/work for you? I can also take the PRs down and reopen them later down the line once we have more of this thought out! |
Leaving them open as drafts sounds great! |
work to fulfill: https://github.com/posit-dev/connect/issues/31840
Very open to feedback on how best to market/present this gallery app since it's so reliant on specific users being given the correct data action roles to access an Azure OpenAI model deployment. I tried my best to document this in the "Usage" section of the
README.md
.This app has been deployed as an example here, but only members of the "Connect" user group will be able to properly interact with it.