Skip to content

Conversation

@Gideilson-Lima
Copy link
Contributor

Now it's possible to get all the documents from big collections and perform all query methods appwrite supports excepts search because I don't really understand what it does exactly and how it is related to indexes.

@Gideilson-Lima Gideilson-Lima reopened this Apr 6, 2025

int count=0;
for(std::list<std::string>::iterator iter = queries.begin();count < index+1; count++, iter++){
// for safety, let's make the private iterators point somewhere before deleting
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh my Gawd ://

Copy link
Owner

@pooranjoyb pooranjoyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, dude :)
Appreciate the fact that you actually didn't miss anything, just pure buttery code.

@pooranjoyb pooranjoyb moved this to In Progress in C++ SDK Appwrite Apr 8, 2025
@pooranjoyb pooranjoyb added touch-of-magic Smiles Guaranteed (enhancements) escalate-to-the-gods peak coding needed here labels Apr 8, 2025
@pooranjoyb pooranjoyb merged commit 2fde6f1 into pooranjoyb:develop Apr 8, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in C++ SDK Appwrite Apr 8, 2025
@Gideilson-Lima
Copy link
Contributor Author

Awesome, dude :) Appreciate the fact that you actually didn't miss anything, just pure buttery code.

Thanks for creating this SDK and allowing me to contribute in some way :)

@pooranjoyb
Copy link
Owner

Thanks for creating this SDK and allowing me to contribute in some way :)

You are welcome to contribute more. We'll be glad <3

@Gideilson-Lima
Copy link
Contributor Author

Hey man. Our Query class is not compatible with appwrite 1.7 because they changed the request format.
In version 1.6 it was simply an escaped json string that we would append to the GET method like this:
queries[]={\"method\":\"equal\",\"attribute\":\"title\",\"values\":[\"Avatar\"]}

but now in version 1.7, it requires a URL encoded string like:
queries[]=%7B%22method%22%3A%22equal%22%2C%22attribute%22%3A%22title%22%2C%22values%22%3A%5B%22Avatar%22%5D%7D

In my personal project I simply hardcoded again replacing the old request style and it's working fine, but what do you suggest? Should we keep 1.6 queries format or totally replace it for this new one?

P.S. Personally I don't understand why they did this. Everytime we have square brackets "[ ]" in the query we now replace for %5B %5D but in the beginning of the string they kept the square brackets queries[] for some reason.

@pooranjoyb
Copy link
Owner

In my personal project I simply hardcoded again replacing the old request style and it's working fine, but what do you suggest? Should we keep 1.6 queries format or totally replace it for this new one?

I think it's better if we go on with the stable 1.6.x version as of now. coz this minor change could bring up many discrepancies in the queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

escalate-to-the-gods peak coding needed here touch-of-magic Smiles Guaranteed (enhancements)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants