Skip to content

Fix issues #32, #38, rest-json APIs in general and improve performance significantly #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Fix issues #32, #38, rest-json APIs in general and improve performance significantly #39

wants to merge 19 commits into from

Conversation

@cdmojoli
Copy link

@cdmojoli cdmojoli commented Jan 18, 2025

This fixes issue #38.

Additionally, it improves performance as described in #10 (comment) and #10 (comment).

@cdmojoli
HTTP requests to AWS enable keep-alive for HTTP by default.
d7b20f9 
You can disable keep-alive with (SETF AWS-REQUEST/API::*KEEP-ALIVE* NIL).
@cdmojoli
add-query-with-input returns strings to use as proper request paths.
65ce839
@cdmojoli
Missing import resulted in locally interned REST-JSON-REQUEST
7e91895 
which resulted in non-functional code for all services using this API
style.
@cdmojoli
URI-ENCODE for AWS-SIGN4 was not spec compliant.
c066bdb
@cdmojoli
X-Amz-Content-Sha256 now added to headers prior to signing them, as r…
add18d2 
…equired.
@cdmojoli
Payloads are no longer sent as query params.
8141451 
I am mostly –but not entirely– sure about this commit. It works
for me; I needed this for the lambda INVOKE API, and AFAIK has not
broken anything, but YMMV.
@cdmojoli
Regenerated all services with the recent committed changes.
b2593d5 
For me, it means that I can now

(READ
 (AWS/LAMBDA:INVOKE
  :FUNCTION-NAME "arn:aws:lambda:us-east-1:123456789012:function:MY-LAMBDA-FN-NAME"
  :PAYLOAD "{\"key1\" : \"value1\"}"))
@cdmojoli cdmojoli changed the title Fix issue #38 and improve performance significantly Fix issues #32, #38, rest-json APIs in general and improve performance significantly Feb 18, 2025
@cdmojoli
Copy link
Author

cdmojoli commented Feb 18, 2025

I have extended my pull request to cover more updates to aws-sdk-lisp. I needed lambda service working, and it didn't, so I hacked until it worked (for me). I am sure I needed these changes, but whether they are universally correct is TBD.

Now I can

(READ
 (AWS/LAMBDA:INVOKE
  :FUNCTION-NAME "arn:aws:lambda:us-east-1:123456789012:function:MY-LAMBDA-FN-NAME"
  :PAYLOAD "{\"key1\" : \"value1\"}"))

(I really needed that. I am currently using aws-sdk-lisp for DynamoDB and Lambda.)

@cdmojoli cdmojoli mentioned this pull request Feb 18, 2025
Open
@cdmojoli cdmojoli mentioned this pull request Mar 8, 2025
Open
fukamachi and others added 12 commits May 1, 2025 06:47
@fukamachi
Support IMDSv2.
2ce2cc8
@fukamachi
Fix the type mismatch at :path.
db376e9 
ref pokepay#37
@fukamachi
Add the implementation to request in REST-XML format (ex. S3).
15b7f38
@fukamachi
Re-generated.
23cc82b
@fukamachi
Use uiop:define-package.
4b2af23
@fukamachi
Re-generated.
5f34fa1
@fukamachi
Don't parse an empty body as XML.
4bc8cdd
@cdmojoli
Merge pull request #1 from fukamachi/master
f76c05e 
Pull in Fukumachi's advances.
@cdmojoli
Revert "add-query-with-input returns strings to use as proper request…
97e04c3 
… paths."

Fukamachi introduced a solution at a different point in commit
15b7f38 (Add the implementation to request in REST-XML format). Both
cannot coexist. Given he is the original author, I trust his judgement better.

This reverts commit 65ce839.
@cdmojoli
Remove debug declaration that should not have made it to the repo.
23c79f7
@fukamachi
Fix a wrong logic to tell valid tokens for IMDSv2.
55f9437 
ref. 2ce2cc8
@cdmojoli
Merge pull request #2 from fukamachi/master
7e32b85 
Fix a wrong logic to tell valid tokens for IMDSv2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cdmojoli @fukamachi