Type-safe CREATE TEMPORARY TRIGGER builder
#82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove trailing comma while we support Swift 6.0 * compile for swift 6.0
* Add `QueryExpression<Optional>.map,flatMap`
This PR adds helpers that make it a little easier to work with optional
query expressions in a builder.
For example, if you want to execute a `LIKE` operator on an optional
string, you currently have to resort to one of the following
workarounds:
```swift
.where { ($0.title ?? "").like("%foo%") }
// or:
.where { #sql("\($0.title) LIKE '%foo%') }
```
This PR introduces `map` and `flatMap` operations on optional
`QueryExpression`s that unwraps the expression, giving you additional
flexibility in how you express your builder code:
```swift
.where { $0.title.map { $0.like("%foo%") } ?? false }
```
While this is more code than the above options, some may prefer its
readability, and should we merge the other optional helpers from #61, it
could be further shortened:
```swift
.where { $0.title.map { $0.like("%foo%") } }
```
* tests
This reverts commit a3de95c.
stephencelis
added a commit
that referenced
this pull request
Sep 17, 2025
Like temporary triggers (#82), temporary views can be created in a completely type-safe manner due to their transitive nature.
stephencelis
added a commit
that referenced
this pull request
Sep 17, 2025
* Add type-safe API for creating temporary views Like temporary triggers (#82), temporary views can be created in a completely type-safe manner due to their transitive nature. * wip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary triggers always work with the most up-to-date schema, and thus are safe to build with the type-safe schema representation provided by the library.