Swift 5.8 Support #289
Merged
Swift 5.8 Support #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jaap Wijnen <[email protected]>
Closed
* Downstream ParseBuilder should use Downstream.Input as Input The ParseBuilder is for Downstream so it should use it’s input. Or Upstream.Output as pipe runs the downstream parser on the output of the upstream parser. Which is why Upstream.Output == Downstream.Input. With the 5.8 changes pipe uses the wrong input here. This only causes issues, if Upstream and Downstream have a different Input type. * Pipe - Use Upstream.Output instead of Downstream.Input
mbrandonw
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prepare for the release of Xcode 14.3 and Swift 5.8, Parsing must make some breaking changes. This PR overhauls the
ParserBuilderandOneOfBuilderto be compatible with Swift 5.8's new result builder implementation. Apple's decided to make breaking changes to result builders to improve their performance, and so we must adapt accordingly. Because of this, upgrading a project using Parsing to Swift 5.8 may not be trivial, but we'll do our best to describe the what, why, and how in an associated discussion.