-
-
Notifications
You must be signed in to change notification settings - Fork 111
numeric slider #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numeric slider #346
Conversation
@aulneau do you think you could help me out with the CSS here please? Here's a side-by-side of old vs new... we don't have to get all the way to 'old' but partway would be nice :) I already copied the default styles and hacked them somewhat to get from huge/green to small/ grey ;) |
export const NumericFraction = connectToContainer(UnconnectedNumericFraction, { | ||
modifyPlotProps: numericFractionModifyPlotProps, | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, so this is my general control for when I want a slider instead of a standard numeric.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only if you want it to be expressed as a percentage! if your min is 2 and your max is 4 then 50% = 3 etc... if you want a slider from 2 to 3 you should use <Numeric showSlider ... >
looks good 💃 after stylings! |
@nicolaskruchten I can check this out tonight / tomorrow AM! |
@@ -40,6 +40,7 @@ | |||
} | |||
&__title { | |||
width: 30%; | |||
//flex-shrink:0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be enabled. The titles should all be the same width, but if I keep this on, certain tabs will escape the boundaries of the content area of the field. @nicolaskruchten @VeraZab what do you two think of changing these fields that have the radio buttons (3+) into a label on top, and then a full width field widget?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with your proposal.
No description provided.