Bump eslint to v8.14 and remove window typeof check in registry
#6181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
commented
May 6, 2022
src/registry.js
Outdated
| @@ -276,7 +276,7 @@ function registerTraceModule(_module) { | |||
| // add `PlotlyGeoAssets` global to stash references to all fetched | |||
| // topojson / geojson data | |||
| if((bpmName === 'geo' || bpmName === 'mapbox') && | |||
| (typeof window !== undefined && window.PlotlyGeoAssets === undefined) | |||
| (typeof window !== 'undefined' && window.PlotlyGeoAssets === undefined) | |||
There was a problem hiding this comment.
The condition here is still not strict enough.
I suggest we use:
Suggested change
| (typeof window !== 'undefined' && window.PlotlyGeoAssets === undefined) | |
| (typeof window === 'object' && window.PlotlyGeoAssets === undefined) |
There was a problem hiding this comment.
That's the only place we do typeof window at all, everywhere else we just assume it's present. Given that as is it's always going to give true, can't we just remove that condition?
There was a problem hiding this comment.
We also test for window here:
plotly.js/src/lib/is_plain_object.js
Line 9 in 73e05ce
archmoj
changed the title
eslint to v8.14 and fix window typeof comparison value in registryeslint to v8.14 and remove window typeof check in registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New valid-typeof rule catch what appears to be a bug in
src/registry.@plotly/plotly_js